fix: nuxt module not passing options correctly

juliusmarminge commented 1 month ago

Closes #1014

Summary by CodeRabbit

Bug Fixes
- Resolved an issue with the upload handler by ensuring options are correctly forwarded.
New Features
- Simplified configuration process for the upload settings by allowing all properties to be included without explicit listing.
Documentation
- Updated TypeScript interface to reflect the removal of secret and appId properties.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 7bb47cc822efa581c0f45b5eec433c783c557bf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ----------------- | ----- | | @uploadthing/nuxt | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-uploadthing	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 16, 2024 8:13am

1 Skipped Deployment

coderabbitai[bot] commented 1 month ago

Walkthrough

This pull request introduces a patch for the @uploadthing/nuxt package, ensuring that options are correctly forwarded to the upload handler. It modifies the ModuleOptions TypeScript interface by removing the secret and appId properties. Additionally, the handling of nuxt.options.runtimeConfig.uploadthing is updated to merge the entire options object instead of specific properties. These changes aim to simplify the configuration process while maintaining existing module setup functionalities.

Changes

File Path	Change Summary
.changeset/sharp-needles-collect.md	Introduced patch for `@uploadthing/nuxt` package; fixed options forwarding.
packages/nuxt/src/module.ts	Updated `ModuleOptions` interface; removed `secret` and `appId`; changed options merging in `setup` function.

Assessment against linked issues

Objective	Addressed	Explanation
Fix invalid server configuration issue (#1014)	✅

🐇 In the patch, options flow with glee,
No more bugs, just harmony!
With secrets and IDs now out of sight,
Configuration’s simpler, everything feels right!
So hop along, let’s upload with cheer,
A smoother process, let’s give a big cheer! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

github-actions[bot] commented 1 month ago

📦 Bundle size comparison

Bundle	Size (gzip)	Visualization
Main	26.11KB	See Treemap 📊
PR (7b095642a2a456544bac9fdea8b6eb3e1b12ad36)	26.11KB	See Treemap 📊
Diff	No change

pkg-pr-new[bot] commented 1 month ago

Open in Stackblitz

More templates

- [@example/minimal-appdir](https://pkg.pr.new/template/1fbd4dd6-343e-4242-b5ae-dfdcbc7f5fa0) - [@example/minimal-astro-react](https://pkg.pr.new/template/6da42cc0-428a-445d-ab6f-25e25df40d89) - [@example/minimal-expo](https://pkg.pr.new/template/c615ea6e-9c7f-4b13-927b-b92826fe9c33) - [@example/minimal-nuxt](https://pkg.pr.new/template/b49dc046-fba2-420b-8a96-20f4457cbfcc) - [@example/minimal-pagedir](https://pkg.pr.new/template/55254b61-ee2f-4e50-b211-3bb76c0c72e1) - [@example/minimal-solidstart](https://pkg.pr.new/template/40fdb9f1-3319-4f5d-ae39-f0981ab55671) - [@example/minimal-sveltekit](https://pkg.pr.new/template/0313e60a-8af0-4f68-8fdc-625d9f5202ce) - [@example/minimal-tanstack-start](https://pkg.pr.new/template/a143b4ac-8564-423b-9959-be513a0ceb6b)

pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/nuxt@1018

commit: 7bb47cc

github-actions[bot] commented 1 month ago

A new canary is available for testing. You can install this latest build in your project with:

pnpm add @uploadthing/expo@7.0.4-canary.266d605
pnpm add @uploadthing/mime-types@0.3.1-canary.266d605
pnpm add @uploadthing/nuxt@7.0.4-canary.266d605
pnpm add @uploadthing/react@7.0.4-canary.266d605
pnpm add @uploadthing/shared@7.0.4-canary.266d605
pnpm add @uploadthing/solid@7.0.4-canary.266d605
pnpm add @uploadthing/svelte@7.0.4-canary.266d605
pnpm add uploadthing@7.1.1-canary.266d605
pnpm add @uploadthing/vue@7.0.4-canary.266d605

pingdotgg / uploadthing