Closed juliusmarminge closed 2 weeks ago
Latest commit: f913eb537570bba904c2c2b5c330d68393fcd398
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
docs-uploadthing | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 4, 2024 10:56pm |
[!WARNING]
Rate limit exceeded
@juliusmarminge has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 34 seconds before requesting another review.
⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.📥 Commits
Reviewing files that changed from the base of the PR and between 1123db247760eaff91f692bfb8727d49613332dd and f913eb537570bba904c2c2b5c330d68393fcd398.
The changes introduce a dynamic approach to style inclusion in a Nuxt application, specifically determining whether to add a stylesheet or a Tailwind plugin based on the presence of the @nuxtjs/tailwindcss
package. This involves updates to several files, including the addition of the Tailwind CSS module in the configuration, enhancements to the module's functionality, and the introduction of a new Tailwind plugin for custom variants. Visual updates to the UI components are also included, ensuring that the application can adapt its styling based on available dependencies.
File Path | Change Summary |
---|---|
.changeset/little-boxes-taste.md | Introduced logic for conditional inclusion of styles based on @nuxtjs/tailwindcss package. |
packages/nuxt/playground/app.vue | Updated <div> element to include additional CSS classes for enhanced styling. |
packages/nuxt/playground/nuxt.config.ts | Added @nuxtjs/tailwindcss to the modules array in the Nuxt configuration. |
packages/nuxt/playground/package.json | Added @nuxtjs/tailwindcss as a dependency in devDependencies . |
packages/nuxt/src/module.ts | Enhanced module functionality with new imports and conditional style injection logic. |
packages/uploadthing/src/tw.ts | Introduced uploadthingPlugin for custom Tailwind CSS variants and removed the old utPlugin . |
pnpm-workspace.yaml | Added packages/nuxt/playground to the workspace packages. |
withUt
function in the packages/uploadthing/src/tw.ts
file to improve module resolution, which is directly related to the changes in the main PR that enhance the handling of styles based on the presence of Tailwind CSS.ModuleOptions
interface in packages/nuxt/src/module.ts
, which is relevant to the main PR's changes that involve conditional logic for including styles based on the @nuxtjs/tailwindcss
package.📚 documentation
, examples
🐰 In the garden, styles do bloom,
With Tailwind's touch, we make room.
A plugin here, a class added there,
Our playground's bright, with flair to spare!
So hop along, let colors play,
In our Nuxt world, we style the day! 🌼✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
A new canary is available for testing. You can install this latest build in your project with:
pnpm add @uploadthing/expo@7.1.1-canary.56681d4
pnpm add @uploadthing/mime-types@0.3.2-canary.56681d4
pnpm add @uploadthing/nuxt@7.1.1-canary.56681d4
pnpm add @uploadthing/react@7.1.1-canary.56681d4
pnpm add @uploadthing/shared@7.1.1-canary.56681d4
pnpm add @uploadthing/solid@7.1.1-canary.56681d4
pnpm add @uploadthing/svelte@7.1.1-canary.56681d4
pnpm add uploadthing@7.2.1-canary.56681d4
pnpm add @uploadthing/vue@7.1.1-canary.56681d4
Bundle | Size (gzip) | Visualization |
---|---|---|
Main | 27.50KB | See Treemap 📊 |
PR (ba52442b3d47996d8963db4ee87843288aa10c1b) | 27.50KB | See Treemap 📊 |
Diff | No change |
- [@example/minimal-appdir](https://pkg.pr.new/template/6bab05a0-40d8-499b-b519-dee890af0c1d) - [@example/minimal-astro-react](https://pkg.pr.new/template/3f5795cb-9ad4-47aa-a52e-760eb4513d94) - [@example/minimal-expo](https://pkg.pr.new/template/b410286f-b6ea-4536-8a9b-75b41cc27342) - [@example/minimal-nuxt](https://pkg.pr.new/template/0ba29d24-4585-4d85-b8a2-a5eb1436087d) - [@example/minimal-pagedir](https://pkg.pr.new/template/f875f545-866c-4776-8b3b-05938e5a4d43) - [@example/minimal-solidstart](https://pkg.pr.new/template/bb96b32a-d642-4e04-90e3-976d3e982cb7) - [@example/minimal-sveltekit](https://pkg.pr.new/template/d601158a-3040-4a70-ac3f-13afae866b5c) - [@example/minimal-tanstack-start](https://pkg.pr.new/template/cb7055ff-ea7f-4a5d-83d0-21879e011146)
pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/nuxt@1033
pnpm add https://pkg.pr.new/pingdotgg/uploadthing@1033
commit: f913eb5
Hey @danielroe would you mind checking if this adheres to conventions or if I'm doing something silly here :)
Thanks!
Checks if the user is using tailwind and if they are, we inject our tailwind plugin instead of the stylesheet
Summary by CodeRabbit
Release Notes
New Features
@nuxtjs/tailwindcss
package, enhancing configuration flexibility.Improvements
@nuxtjs/tailwindcss
module.Chores
@nuxtjs/tailwindcss
dependency to project configurations.