pingdotgg / uploadthing

File uploads for modern web devs
https://uploadthing.com
MIT License
4.26k stars 315 forks source link

fix: nuxt module tailwind support #1033

Closed juliusmarminge closed 2 weeks ago

juliusmarminge commented 4 weeks ago

Checks if the user is using tailwind and if they are, we inject our tailwind plugin instead of the stylesheet

Summary by CodeRabbit

Release Notes

changeset-bot[bot] commented 4 weeks ago

🦋 Changeset detected

Latest commit: f913eb537570bba904c2c2b5c330d68393fcd398

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ----------------- | ----- | | uploadthing | Patch | | @uploadthing/nuxt | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 10:56pm
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **legacy-docs-uploadthing** | ⬜️ Ignored ([Inspect](https://vercel.com/pinglabs/legacy-docs-uploadthing/GRzJqZ4YhtQmQmKWXJspqEkFNcUn)) | [Visit Preview](https://legacy-docs-uploadthing-git-nuxt-module-tailwind-pinglabs.vercel.app) | | Nov 4, 2024 10:56pm |
coderabbitai[bot] commented 4 weeks ago

[!WARNING]

Rate limit exceeded

@juliusmarminge has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 34 seconds before requesting another review.

⌛ How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
📥 Commits Reviewing files that changed from the base of the PR and between 1123db247760eaff91f692bfb8727d49613332dd and f913eb537570bba904c2c2b5c330d68393fcd398.

Walkthrough

The changes introduce a dynamic approach to style inclusion in a Nuxt application, specifically determining whether to add a stylesheet or a Tailwind plugin based on the presence of the @nuxtjs/tailwindcss package. This involves updates to several files, including the addition of the Tailwind CSS module in the configuration, enhancements to the module's functionality, and the introduction of a new Tailwind plugin for custom variants. Visual updates to the UI components are also included, ensuring that the application can adapt its styling based on available dependencies.

Changes

File Path Change Summary
.changeset/little-boxes-taste.md Introduced logic for conditional inclusion of styles based on @nuxtjs/tailwindcss package.
packages/nuxt/playground/app.vue Updated <div> element to include additional CSS classes for enhanced styling.
packages/nuxt/playground/nuxt.config.ts Added @nuxtjs/tailwindcss to the modules array in the Nuxt configuration.
packages/nuxt/playground/package.json Added @nuxtjs/tailwindcss as a dependency in devDependencies.
packages/nuxt/src/module.ts Enhanced module functionality with new imports and conditional style injection logic.
packages/uploadthing/src/tw.ts Introduced uploadthingPlugin for custom Tailwind CSS variants and removed the old utPlugin.
pnpm-workspace.yaml Added packages/nuxt/playground to the workspace packages.

Possibly related PRs

Suggested labels

📚 documentation, examples

🐰 In the garden, styles do bloom,
With Tailwind's touch, we make room.
A plugin here, a class added there,
Our playground's bright, with flair to spare!
So hop along, let colors play,
In our Nuxt world, we style the day! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 4 weeks ago

A new canary is available for testing. You can install this latest build in your project with:

pnpm add @uploadthing/expo@7.1.1-canary.56681d4
pnpm add @uploadthing/mime-types@0.3.2-canary.56681d4
pnpm add @uploadthing/nuxt@7.1.1-canary.56681d4
pnpm add @uploadthing/react@7.1.1-canary.56681d4
pnpm add @uploadthing/shared@7.1.1-canary.56681d4
pnpm add @uploadthing/solid@7.1.1-canary.56681d4
pnpm add @uploadthing/svelte@7.1.1-canary.56681d4
pnpm add uploadthing@7.2.1-canary.56681d4
pnpm add @uploadthing/vue@7.1.1-canary.56681d4
github-actions[bot] commented 4 weeks ago

📦 Bundle size comparison

Bundle Size (gzip) Visualization
Main 27.50KB See Treemap 📊
PR (ba52442b3d47996d8963db4ee87843288aa10c1b) 27.50KB See Treemap 📊
Diff No change
pkg-pr-new[bot] commented 4 weeks ago

Open in Stackblitz

More templates

- [@example/minimal-appdir](https://pkg.pr.new/template/6bab05a0-40d8-499b-b519-dee890af0c1d) - [@example/minimal-astro-react](https://pkg.pr.new/template/3f5795cb-9ad4-47aa-a52e-760eb4513d94) - [@example/minimal-expo](https://pkg.pr.new/template/b410286f-b6ea-4536-8a9b-75b41cc27342) - [@example/minimal-nuxt](https://pkg.pr.new/template/0ba29d24-4585-4d85-b8a2-a5eb1436087d) - [@example/minimal-pagedir](https://pkg.pr.new/template/f875f545-866c-4776-8b3b-05938e5a4d43) - [@example/minimal-solidstart](https://pkg.pr.new/template/bb96b32a-d642-4e04-90e3-976d3e982cb7) - [@example/minimal-sveltekit](https://pkg.pr.new/template/d601158a-3040-4a70-ac3f-13afae866b5c) - [@example/minimal-tanstack-start](https://pkg.pr.new/template/cb7055ff-ea7f-4a5d-83d0-21879e011146)

pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/nuxt@1033
pnpm add https://pkg.pr.new/pingdotgg/uploadthing@1033

commit: f913eb5

juliusmarminge commented 3 weeks ago

Hey @danielroe would you mind checking if this adheres to conventions or if I'm doing something silly here :)

Thanks!