Closed juliusmarminge closed 6 months ago
Latest commit: c75b45887615269405e08e40dd737449042d7e4f
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
docs-uploadthing | ✅ Ready (Inspect) | Visit Preview | Mar 10, 2024 10:04am |
A new canary is available for testing. You can install this latest build in your project with:
pnpm add @uploadthing/dropzone@0.2.2-canary.eefdb6c
pnpm add @uploadthing/mime-types@0.2.7-canary.eefdb6c
pnpm add @uploadthing/react@6.3.5-canary.eefdb6c
pnpm add @uploadthing/shared@6.3.5-canary.eefdb6c
pnpm add @uploadthing/solid@6.2.2-canary.eefdb6c
pnpm add uploadthing@6.5.3-canary.eefdb6c
do we need full fetch override? or is headers enough? or both?
I can't really think of reasons why you would actually need a full fetch override, headers only is probably fine. IF other things are needed in the future we can reassess.
is it even useful at all to have it on the generators?
Probably not. I think having it on the hook/components is probably more flexible for the user.
Superseded by #705
quickly spun up the ability to allow fetch override to set headers. Ref: https://discord.com/channels/966627436387266600/1102510616326967306/1216240077605310576
Questions
headers
enough? or both?genUploader
,generateReactHelpers
,generateUploadButton
etc etc. Maybe we should also have a way to allow this override when doing the call / on the components? Thinking if the token requires React context?