pingdotgg / uploadthing

File uploads for modern web devs
https://uploadthing.com
MIT License
3.87k stars 282 forks source link

chore: rename solid helper to `createUploadThing` #747

Open juliusmarminge opened 4 months ago

juliusmarminge commented 4 months ago

Ref: https://github.com/pingdotgg/uploadthing/pull/225#issuecomment-2041461668

Follows createSignal, createEffect, createMemo etc etc, as well as some community libs (createQuery for TanStack Query for example)

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: a7dbd4a93f124dd0249d0c843e6a42e6415a7ebe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------ | ----- | | @uploadthing/solid | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ❌ Failed (Inspect) Jun 28, 2024 8:17pm
markflorkowski commented 3 months ago

Not sure if it matters, but we use createUploadthing() for creating the router on the backend already...

N0tExisting commented 2 months ago

Not sure if it matters, but we use createUploadthing() for creating the router on the backend already...

should be fine, because its only exported in the uploadthing/server package and only imported once in server side code, making any conflicts quite unlikely.

markflorkowski commented 2 months ago

making any conflicts quite unlikely.

less concerned about actual code related conflicts, more about it being confusing for users.

github-actions[bot] commented 2 months ago

📦 Bundle size comparison

Bundle Size (gzip) Visualization
Main 39.70KB See Treemap 📊
PR (4e49624edc7be8308e6b0888dc3e875d9d65defe) 39.70KB See Treemap 📊
Diff No change