search

pingdotgg / uploadthing

File uploads for modern web devs
https://uploadthing.com
MIT License
3.74k stars 267 forks source link

feat: added onDrop prop for UploadDropzone component #809

Closed growupanand closed 2 months ago

growupanand commented 2 months ago

Added a prop onDrop for the <UploadDropzone /> component. Whenever the user selects or drops the file it will call the passed onDrop callback function.

Closes #805

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 5b5652e058f81088634762071500886d9e0f109c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------ | ----- | | @uploadthing/react | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 9:30am
growupanand commented 2 months ago

I have updated docs and added changeset.

growupanand commented 2 months ago

can you please merge this PR?

juliusmarminge commented 2 months ago

I am currently fixing our CI.

Seems like something broke in Node 20.13 which the runners seems to use since last night.

Will merge once everything's green 👍🏼

growupanand commented 2 months ago

Hey @juliusmarminge ,

In my project, I am trying to publish a internal package of turborepo. I am able to bundle it successfully and published it. But when I am trying to use it in another react app, I am facing below error. Can you please help me with that whenever you got some time?

╰─$ npm install @convoform/react                                                                                                                                                                            130 ↵
npm ERR! code EUNSUPPORTEDPROTOCOL
npm ERR! Unsupported URL Type "workspace:": workspace:*

Message here since I was not able to contact you on LinkedIn or Twitter 😅

https://github.com/growupanand/ConvoForm/commits/231-publish-react-hook-as-npm-package/

juliusmarminge commented 2 months ago

Hey @juliusmarminge ,

In my project, I am trying to publish a internal package of turborepo. I am able to bundle it successfully and published it. But when I am trying to use it in another react app, I am facing below error. Can you please help me with that whenever you got some time?

╰─$ npm install @convoform/react                                                                                                                                                                            130 ↵
npm ERR! code EUNSUPPORTEDPROTOCOL
npm ERR! Unsupported URL Type "workspace:": workspace:*

Message here since I was not able to contact you on LinkedIn or Twitter 😅

https://github.com/growupanand/ConvoForm/commits/231-publish-react-hook-as-npm-package/

You cannot use workspace:* in published packages since the consumer won't have that workspace reference.

If you publish with pnpm it should replace the workspace:* with the proper version for you, but if you use npm you'll need to do it yourself.

If you don't wish to also publish the dependency, you'll have to bundle it into the @convoform/react dist

Hope that helps!

growupanand commented 2 months ago

Hey @juliusmarminge , In my project, I am trying to publish a internal package of turborepo. I am able to bundle it successfully and published it. But when I am trying to use it in another react app, I am facing below error. Can you please help me with that whenever you got some time?

╰─$ npm install @convoform/react                                                                                                                                                                            130 ↵
npm ERR! code EUNSUPPORTEDPROTOCOL
npm ERR! Unsupported URL Type "workspace:": workspace:*

Message here since I was not able to contact you on LinkedIn or Twitter 😅 https://github.com/growupanand/ConvoForm/commits/231-publish-react-hook-as-npm-package/

You cannot use workspace:* in published packages since the consumer won't have that workspace reference.

If you publish with pnpm it should replace the workspace:* with the proper version for you, but if you use npm you'll need to do it yourself.

If you don't wish to also publish the dependency, you'll have to bundle it into the @convoform/react dist

Hope that helps!

Hey @juliusmarminge , In my project, I am trying to publish a internal package of turborepo. I am able to bundle it successfully and published it. But when I am trying to use it in another react app, I am facing below error. Can you please help me with that whenever you got some time?

╰─$ npm install @convoform/react                                                                                                                                                                            130 ↵
npm ERR! code EUNSUPPORTEDPROTOCOL
npm ERR! Unsupported URL Type "workspace:": workspace:*

Message here since I was not able to contact you on LinkedIn or Twitter 😅 https://github.com/growupanand/ConvoForm/commits/231-publish-react-hook-as-npm-package/

You cannot use workspace:* in published packages since the consumer won't have that workspace reference.

If you publish with pnpm it should replace the workspace:* with the proper version for you, but if you use npm you'll need to do it yourself.

If you don't wish to also publish the dependency, you'll have to bundle it into the @convoform/react dist

Hope that helps!

Hey @juliusmarminge , In my project, I am trying to publish a internal package of turborepo. I am able to bundle it successfully and published it. But when I am trying to use it in another react app, I am facing below error. Can you please help me with that whenever you got some time?

╰─$ npm install @convoform/react                                                                                                                                                                            130 ↵
npm ERR! code EUNSUPPORTEDPROTOCOL
npm ERR! Unsupported URL Type "workspace:": workspace:*

Message here since I was not able to contact you on LinkedIn or Twitter 😅 https://github.com/growupanand/ConvoForm/commits/231-publish-react-hook-as-npm-package/

You cannot use workspace:* in published packages since the consumer won't have that workspace reference.

If you publish with pnpm it should replace the workspace:* with the proper version for you, but if you use npm you'll need to do it yourself.

If you don't wish to also publish the dependency, you'll have to bundle it into the @convoform/react dist

Hope that helps!

Thanks for the quick reply, I didn't know about that PNPM could insert the dependency version.

I have just tried to bundle it in the dist folder. I was able to publish it and then installed it in another React app successfully. But I am not able to use it and getting below error.

Unhandled Runtime Error
Error: Cannot find module 'fs'

Call Stack
webpackEmptyContext
file:///home/growupanand/Development/repos/ConvoForm/apps/web/.next/static/chunks/app/(protectedPage)/forms/%5BformId%5D/page.js (18:10)
__require
../node_modules/.pnpm/engine.io-client@6.5.3/node_modules/engine.io-client/build/cjs/contrib/yeast.js (46:9)
__require2
(app-pages-browser)/../../packages/react/dist/index.js
require_XMLHttpRequest
../node_modules/.pnpm/engine.io-client@6.5.3/node_modules/engine.io-client/build/cjs/transports/xmlhttprequest.js (15:21)
__require2
(app-pages-browser)/../../packages/react/dist/index.js
require_xmlhttprequest
../node_modules/.pnpm/engine.io-client@6.5.3/node_modules/engine.io-client/build/cjs/transports/xmlhttprequest.js (109:5)
__require2
(app-pages-browser)/../../packages/react/dist/index.js
require_polling
../node_modules/.pnpm/engine.io-client@6.5.3/node_modules/engine.io-client/build/cjs/transports/webtransport.js (58:26)
__require2
(app-pages-browser)/../../packages/react/dist/index.js
require_transports
../node_modules/.pnpm/engine.io-client@6.5.3/node_modules/engine.io-client/build/cjs/contrib/parseuri.js (42:13)

Would you kindly assist me with this as well? I would really appreciate it. And I have created an issue here for the discussion.

growupanand commented 2 months ago

Hey @juliusmarminge , In my project, I am trying to publish a internal package of turborepo. I am able to bundle it successfully and published it. But when I am trying to use it in another react app, I am facing below error. Can you please help me with that whenever you got some time?

╰─$ npm install @convoform/react                                                                                                                                                                            130 ↵
npm ERR! code EUNSUPPORTEDPROTOCOL
npm ERR! Unsupported URL Type "workspace:": workspace:*

Message here since I was not able to contact you on LinkedIn or Twitter 😅 https://github.com/growupanand/ConvoForm/commits/231-publish-react-hook-as-npm-package/

You cannot use workspace:* in published packages since the consumer won't have that workspace reference. If you publish with pnpm it should replace the workspace:* with the proper version for you, but if you use npm you'll need to do it yourself. If you don't wish to also publish the dependency, you'll have to bundle it into the @convoform/react dist Hope that helps!

Hey @juliusmarminge , In my project, I am trying to publish a internal package of turborepo. I am able to bundle it successfully and published it. But when I am trying to use it in another react app, I am facing below error. Can you please help me with that whenever you got some time?

╰─$ npm install @convoform/react                                                                                                                                                                            130 ↵
npm ERR! code EUNSUPPORTEDPROTOCOL
npm ERR! Unsupported URL Type "workspace:": workspace:*

Message here since I was not able to contact you on LinkedIn or Twitter 😅 https://github.com/growupanand/ConvoForm/commits/231-publish-react-hook-as-npm-package/

You cannot use workspace:* in published packages since the consumer won't have that workspace reference. If you publish with pnpm it should replace the workspace:* with the proper version for you, but if you use npm you'll need to do it yourself. If you don't wish to also publish the dependency, you'll have to bundle it into the @convoform/react dist Hope that helps!

Hey @juliusmarminge , In my project, I am trying to publish a internal package of turborepo. I am able to bundle it successfully and published it. But when I am trying to use it in another react app, I am facing below error. Can you please help me with that whenever you got some time?

╰─$ npm install @convoform/react                                                                                                                                                                            130 ↵
npm ERR! code EUNSUPPORTEDPROTOCOL
npm ERR! Unsupported URL Type "workspace:": workspace:*

Message here since I was not able to contact you on LinkedIn or Twitter 😅 https://github.com/growupanand/ConvoForm/commits/231-publish-react-hook-as-npm-package/

You cannot use workspace:* in published packages since the consumer won't have that workspace reference. If you publish with pnpm it should replace the workspace:* with the proper version for you, but if you use npm you'll need to do it yourself. If you don't wish to also publish the dependency, you'll have to bundle it into the @convoform/react dist Hope that helps!

Thanks for the quick reply, I didn't know about that PNPM could insert the dependency version.

I have just tried to bundle it in the dist folder. I was able to publish it and then installed it in another React app successfully. But I am not able to use it and getting below error.

Unhandled Runtime Error
Error: Cannot find module 'fs'

Call Stack
webpackEmptyContext
file:///home/growupanand/Development/repos/ConvoForm/apps/web/.next/static/chunks/app/(protectedPage)/forms/%5BformId%5D/page.js (18:10)
__require
../node_modules/.pnpm/engine.io-client@6.5.3/node_modules/engine.io-client/build/cjs/contrib/yeast.js (46:9)
__require2
(app-pages-browser)/../../packages/react/dist/index.js
require_XMLHttpRequest
../node_modules/.pnpm/engine.io-client@6.5.3/node_modules/engine.io-client/build/cjs/transports/xmlhttprequest.js (15:21)
__require2
(app-pages-browser)/../../packages/react/dist/index.js
require_xmlhttprequest
../node_modules/.pnpm/engine.io-client@6.5.3/node_modules/engine.io-client/build/cjs/transports/xmlhttprequest.js (109:5)
__require2
(app-pages-browser)/../../packages/react/dist/index.js
require_polling
../node_modules/.pnpm/engine.io-client@6.5.3/node_modules/engine.io-client/build/cjs/transports/webtransport.js (58:26)
__require2
(app-pages-browser)/../../packages/react/dist/index.js
require_transports
../node_modules/.pnpm/engine.io-client@6.5.3/node_modules/engine.io-client/build/cjs/contrib/parseuri.js (42:13)

Would you kindly assist me with this as well? I would really appreciate it. And I have created an issue here for the discussion.

It is fixed.