pingdotgg / uploadthing

File uploads for modern web devs
https://uploadthing.com
MIT License
3.74k stars 267 forks source link

fix: Node 20.13 compat #813

Closed juliusmarminge closed 2 months ago

juliusmarminge commented 2 months ago

Seems like something in Node 20.13 is broken with the spread operator on Headers:

image

Symbols aren't enumerable so they shouldn't show up after a spread, yet they are...

Anyways, this refactor makes it compat with this new behavior, be it intentional or unintentional from their side...

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 11:20am
changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 668d35b28019e8b3b92e0a42578b061ea01ce41c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages | Name | Type | | ------------------- | ----- | | uploadthing | Patch | | @uploadthing/shared | Patch | | @uploadthing/nuxt | Patch | | @uploadthing/react | Patch | | @uploadthing/solid | Patch | | @uploadthing/svelte | Patch | | @uploadthing/vue | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

juliusmarminge commented 2 months ago

Opened an issue on Undici: https://github.com/nodejs/undici/issues/3267