search

pingdotgg / uploadthing

File uploads for modern web devs
https://uploadthing.com
MIT License
3.95k stars 285 forks source link

style(website): add scroll bar to improve accessibility #894

Closed MichaHuhn closed 1 month ago

MichaHuhn commented 1 month ago

I understand that this issue may be closed if it should be filed in another category

My issue

The uploadthing website doesn't have a scroll bar in Chrome, Edge, and Opera GX.

It would be beneficial to add one to improve accessibility.

markflorkowski commented 1 month ago

Just merged a change that should bring back scrollbars. Let me know if it is better @MichaHuhn

MichaHuhn commented 1 month ago

Works perfectly. Thank you!

MichaHuhn commented 1 month ago

@markflorkowski I just noticed that this change created a horizontal scroll bar.

The w-screen class on the <body> is probably causing this issue. When I remove it, the horizontal scroll bar disappears.

(I didn't notice it a few minutes ago, because the lightgray scroll bar has a white background.)

markflorkowski commented 1 month ago

Good catch, just pushed up a fix, should be deployed shortly