pingdotgg / uploadthing

File uploads for modern web devs
https://uploadthing.com
MIT License
4.04k stars 295 forks source link

[bug]: KMZ File Upload Not Recognized When Specified as MIME Type #949

Open oliverox opened 3 days ago

oliverox commented 3 days ago

Provide environment information

System:
    OS: macOS 14.6.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 1.99 GB / 16.00 GB
    Shell: 3.3.1 - /usr/local/bin/fish
  Binaries:
    Node: 20.11.1 - ~/.nvm/versions/node/v20.11.1/bin/node
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.1/bin/npm
    pnpm: 9.10.0 - ~/Library/pnpm/pnpm
  Browsers:
    Brave Browser: 128.1.69.162
    Chrome: 128.0.6613.137
    Safari: 17.6
    Safari Technology Preview: 18.0
  npmPackages:
    @uploadthing/react: ^7.0.1 => 7.0.1
    typescript: ^5.6.2 => 5.6.2
    uploadthing: ^7.0.1 => 7.0.1

Describe the bug

When attempting to upload a file with the .kmz extension, the file is not being picked up by UT even if the correct application/vnd.google-earth.kmz+xml MIME type is specified. Moreover, when the file picker dialog shows up, the other non *.kmz files are not disabled. This issue occurs even though other file types work as expected with their corresponding MIME types.

Link to reproduction

https://stackblitz.com/edit/github-kaem89

To reproduce

Click on "Choose File" to select a .kml file to upload. => Nothing happens.

However, changing the MIME type to "blob" allows the .kml (or any file) to be uploaded successfully.

Additional information

Bug is reproducible on both latest and legacy versions of UT. https://x.com/oliveroxenham/status/1834803745894670599

πŸ‘¨β€πŸ‘§β€πŸ‘¦ Contributing

Code of Conduct

markflorkowski commented 3 days ago

Can you provide sample .kmz and .kml files I can test with?

oliverox commented 2 days ago

I sure can. I am currently travelling but will share as soon as I get some internet access.

oliverox commented 2 days ago

You can get a KML file here: https://utfs.io/f/5Bp1JPFX6nSx9Vh6JEMecTo7vnCiflpF1Q8WNHYE3J4DKS6u

markflorkowski commented 2 days ago

Will take a look at this tomorrow morning!

juliusmarminge commented 2 days ago

it appears my computer doesn't recognize the mime-type here:

CleanShot 2024-09-16 at 10 33 05

markflorkowski commented 2 days ago

Yeah, confirmed on mimtype.io, seems like browser does not detect.

image

We could potentially build in functionality to the components to handle cases like these, though we wouldn't be able to get the filtering in the file selection window, just pre-upload validation.