pingdotgg / uploadthing

File uploads for modern web devs
https://uploadthing.com
MIT License
3.95k stars 285 forks source link

[Bug]: Homepage issue #96

Closed irtaza9 closed 1 year ago

irtaza9 commented 1 year ago

What happened?

Hey @t3dotgg, I mentioned this issue at uploadthing channel over discord but their is no progress till now. Should I do a PR by myself? Check the image.

image

check this or close this issue.

What did you expect to happen?

As I know, @t3dotgg will call me for a PR to resolve this, simple.

Version

BETA

Reproduction Steps

By fixing the css

Reproduction Repository

rn, a big no!

image

I've removed some media queries which are causing this issue.

Relevant log output

No response

Code of Conduct

markflorkowski commented 1 year ago

I don't think those are the only cause of the issue: image

You can also see it very faintly in your original screenshot: image

I am only able to repro this on particularly weird window sizes, so I am not too concerned by it, but if you do manage to track down the cause, I'll be happy to make the required change on the marketing site.

irtaza9 commented 1 year ago

I thing the padding media query is putting the space, check the below ss and share your feedback on it.

image

Output: image

markflorkowski commented 1 year ago

That looks like it does it, going to make that change right now.

markflorkowski commented 1 year ago

Just pushed changes, should deploy in a few minutes 👍

irtaza9 commented 1 year ago

Thank you. Pl share the link of exact directory where you add these changes. It is difficult for me to get the actual file of home page in the project.

markflorkowski commented 1 year ago

They're in a separate (private) repository.