search

pingdotgg / uploadthing

File uploads for modern web devs
https://uploadthing.com
MIT License
4.26k stars 315 forks source link

chore: remove dropzone pacakge #977

Closed juliusmarminge closed 2 months ago

juliusmarminge commented 2 months ago

Summary by CodeRabbit

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 01980dca1a605fdd7608e796ec7454b0289885a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages | Name | Type | | ------------------- | ----- | | @uploadthing/react | Patch | | @uploadthing/shared | Patch | | @uploadthing/solid | Patch | | @uploadthing/svelte | Patch | | @uploadthing/vue | Patch | | @uploadthing/expo | Patch | | uploadthing | Patch | | @uploadthing/nuxt | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 10:42pm
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **legacy-docs-uploadthing** | ⬜️ Ignored ([Inspect](https://vercel.com/pinglabs/legacy-docs-uploadthing/ETFugEB9CAyZMkd99U3HN8dLJu5J)) | [Visit Preview](https://legacy-docs-uploadthing-git-rm-dropzone-package-pinglabs.vercel.app) | | Sep 24, 2024 10:42pm |
coderabbitai[bot] commented 2 months ago

Walkthrough

The pull request updates the package.json file for the solid package by removing the dependency on @uploadthing/dropzone and adding a new dependency on file-selector version 0.6.0. The existing dependency on @uploadthing/shared remains unchanged. Additionally, a new file has been introduced to specify patches for several UploadThing-related packages, and the internal dropzone package has been removed to resolve peer dependency conflicts.

Changes

Files Change Summary
packages/solid/package.json Removed dependency on @uploadthing/dropzone, added file-selector version 0.6.0.
packages/solid/patches.json Introduced a new file specifying patches for UploadThing-related packages.

Possibly related PRs

Suggested reviewers

Poem

🐇 In the meadow where code takes flight,
A dropzone bid farewell, into the night.
With file-selector now in our grasp,
We leap through changes, a joyful clasp.
Hopping along, with each new delight,
Embracing the future, our code shines bright! 🌼

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 09e11617b836ef6863c42ee402ab51e20b206219 and 01980dca1a605fdd7608e796ec7454b0289885a4.
Files selected for processing (1) * .changeset/curly-hornets-chew.md (1 hunks)
Additional comments not posted (2)
.changeset/curly-hornets-chew.md (2)
`1-7`: **LGTM: Changeset file structure is correct.** The changeset file is well-structured, listing the packages that will receive patch updates. This is in line with best practices for managing versioning in a monorepo. --- `9-9`: **Verify the impact of removing the internal dropzone package.** The removal of the internal dropzone package to prevent peer dependency conflicts is a good step towards improving package management. However, it's important to ensure that this change doesn't negatively impact the functionality of the affected packages. Let's verify the impact of this change: Please review the results of these checks to ensure that the removal of the internal dropzone package has been completed successfully across the project.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
pkg-pr-new[bot] commented 2 months ago

Open in Stackblitz

More templates

- [@example/minimal-astro-react](https://pkg.pr.new/template/80827184-3555-40cb-814c-e74f80fd50b7) - [@example/minimal-appdir](https://pkg.pr.new/template/a16eb809-ab62-4f07-aa19-50ce52fa6c44) - [@example/minimal-nuxt](https://pkg.pr.new/template/cc5a6ecf-a900-4bb6-9c98-e4b0a6586aae) - [@example/minimal-expo](https://pkg.pr.new/template/2d5f2301-714a-44c3-aaab-9473e601bfc6) - [@example/minimal-pagedir](https://pkg.pr.new/template/41f68a6e-b9e4-418e-a3aa-87555b9b5241) - [@example/minimal-solidstart](https://pkg.pr.new/template/d03b1842-d1fb-4376-9e7f-703493fccd02) - [@example/minimal-sveltekit](https://pkg.pr.new/template/8947f51e-841e-449c-abea-b972b6b88b24)

@uploadthing/nuxt

``` pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/nuxt@977 ```

@uploadthing/react

``` pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/react@977 ```

@uploadthing/shared

``` pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/shared@977 ```

@uploadthing/solid

``` pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/solid@977 ```

@uploadthing/svelte

``` pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/svelte@977 ```

@uploadthing/vue

``` pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/vue@977 ```

commit: 01980dc

github-actions[bot] commented 2 months ago

📦 Bundle size comparison

Bundle Size (gzip) Visualization
Main 26.03KB See Treemap 📊
PR (0ade0807d3fcbba9030e1231bbfb6da975b98eb5) 26.03KB See Treemap 📊
Diff No change