search

pingdotgg / uploadthing

File uploads for modern web devs
https://uploadthing.com
MIT License
4.26k stars 315 forks source link

fix: dropzone behavior #980

Closed juliusmarminge closed 1 month ago

juliusmarminge commented 2 months ago

closes #965

thought this was fixed in #886

Done

Summary by CodeRabbit

Release Notes

These updates streamline file upload processes and enhance the overall functionality of the application.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 7:20pm
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **legacy-docs-uploadthing** | ⬜️ Ignored ([Inspect](https://vercel.com/pinglabs/legacy-docs-uploadthing/9YNLGH6Fhoe3AiR7Ws21FmQ3iMeN)) | [Visit Preview](https://legacy-docs-uploadthing-git-fix-dropzone-behavior-pinglabs.vercel.app) | | Oct 1, 2024 7:20pm |
changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 3db2694cb5186ddbe9f1b3cfc2a888a7cc49ad91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages | Name | Type | | ------------------- | ----- | | @uploadthing/svelte | Patch | | @uploadthing/react | Patch | | @uploadthing/solid | Patch | | @uploadthing/vue | Patch | | @uploadthing/expo | Patch | | @uploadthing/nuxt | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai[bot] commented 2 months ago

[!WARNING]

Rate limit exceeded

@juliusmarminge has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 33 seconds before requesting another review.

⌛ How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
📥 Commits Files that changed from the base of the PR and between 55ac13a421d365b4fdcb2a62770cee92eac1a08f and 3db2694cb5186ddbe9f1b3cfc2a888a7cc49ad91.

Walkthrough

This pull request introduces significant changes across multiple files, primarily focusing on the removal of the @uploadthing/dropzone package and its associated components. Enhancements have been made to the file upload functionality within the @uploadthing/react, @uploadthing/vue, and @uploadthing/solid packages. The updates include modifications to configuration files, dependency management, and the introduction of new utility types for improved file handling and user interaction.

Changes

Files Change Summary
.gitignore Updated to include new ignore patterns for configuration files.
examples/minimal-appdir/next-env.d.ts Updated TypeScript configuration URL in comments.
package.json Updated turbo package version from 2.1.0 to canary.
packages/dropzone/... Deleted files related to the @uploadthing/dropzone package, including CHANGELOG.md, package.json, and various component files.
packages/react/package.json Removed @uploadthing/dropzone dependency; added file-selector dependency.
packages/react/src/components/button.tsx Modified event handling logic and upload state management in the UploadButton component.
packages/react/src/components/dropzone.tsx Updated UploadDropzone component for improved state management and function simplification.
packages/solid/package.json Removed @uploadthing/dropzone dependency; added file-selector dependency.
packages/solid/src/components/button.tsx Simplified upload handling logic in the UploadButton component.
packages/vue/package.json Removed @uploadthing/dropzone dependency; added file-selector dependency.
packages/vue/src/components/button.tsx Updated upload button functionality and state management.
packages/vue/src/components/dropzone.tsx Enhanced upload handling and state management in the UploadDropzone component.
tooling/eslint-config/package.json Updated eslint-config-turbo version from 2.1.0 to canary.
tooling/tsconfig/base.json Removed path mapping for @uploadthing/dropzone/*.

Assessment against linked issues

Objective Addressed Explanation
Fix multiple file uploads triggering twice (#965) ❓ The changes do not explicitly address this bug.

Possibly related PRs

Suggested reviewers

🐰 In the meadow, I hop with glee,
Changes made, oh so sprightly!
Dropzones dance, files glide with ease,
A joyful leap, a gentle breeze.
Let's celebrate this code so bright,
With every upload, the future's in sight! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 2 months ago

📦 Bundle size comparison

Bundle Size (gzip) Visualization
Main 26.03KB See Treemap 📊
PR (36c15d4c3c5d9bfe36448a9b8a1ce6d93012646a) 26.03KB See Treemap 📊
Diff No change
pkg-pr-new[bot] commented 2 months ago

Open in Stackblitz

More templates

- [@example/minimal-appdir](https://pkg.pr.new/template/beb86bd4-9a28-49bf-b7c3-30ba100b9137) - [@example/minimal-expo](https://pkg.pr.new/template/d63335e7-6365-4fec-8f77-4b5ef12f1a09) - [@example/minimal-nuxt](https://pkg.pr.new/template/793c0716-3a2e-4552-8a72-6f0ff902f4a0) - [@example/minimal-pagedir](https://pkg.pr.new/template/c10b6626-03d7-45d7-8337-64fbd65b78c5) - [@example/minimal-solidstart](https://pkg.pr.new/template/cc750879-30d2-4228-85b7-4255b487c131) - [@example/minimal-sveltekit](https://pkg.pr.new/template/b5789d1c-0e9f-4a6a-9996-e5b071325274) - [@example/minimal-tanstack-start](https://pkg.pr.new/template/69d4ebed-b821-4ae0-b44e-ed37577f634a) - [@example/minimal-astro-react](https://pkg.pr.new/template/c0546c88-aead-4c2d-b94c-ed83b70cbc4a)

@uploadthing/nuxt

``` pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/nuxt@980 ```

@uploadthing/react

``` pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/react@980 ```

@uploadthing/solid

``` pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/solid@980 ```

@uploadthing/svelte

``` pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/svelte@980 ```

@uploadthing/vue

``` pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/vue@980 ```

commit: 3db2694

AlemTuzlak commented 1 month ago

Thanks for the fix!