search

pingdotgg / uploadthing

File uploads for modern web devs
https://uploadthing.com
MIT License
4.13k stars 305 forks source link

chore: Update SolidStart example #984

Closed juraj98 closed 1 week ago

juraj98 commented 1 week ago

When working on example for tanstack/start I ran into CI lint issue because of different versions of vinxi for SolidStart and tanstack/start. I decided to update the solidstart example first. Full list of changes:

I'll update solid start getting started docs next and link the PR here.

@juliusmarminge, this might conflict with #980.

Summary by CodeRabbit

Release Notes

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: 82611ef6cbaadfbbfcc6bf13dfc83b3e9386a926

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai[bot] commented 1 week ago

Walkthrough

This pull request introduces several updates across multiple files in the project. Key changes include updates to the package.json dependencies, the removal of PostCSS and Tailwind CSS configurations, and enhancements to the upload handling logic in the index.tsx file. Additionally, the export structure for upload handlers has been modified for clarity. The TypeScript configuration has also been adjusted to reflect changes in module resolution and type definitions.

Changes

File Path Change Summary
examples/minimal-solidstart/package.json Updated dependencies and added a new script for versioning.
examples/minimal-solidstart/postcss.config.cjs Removed PostCSS configuration file.
examples/minimal-solidstart/src/app.tsx Modified imports and removed title management functionality.
examples/minimal-solidstart/src/entry-client.tsx Added a comment for hot reloading; existing functionality preserved.
examples/minimal-solidstart/src/entry-server.tsx Added a comment for hot reloading; removed favicon link from the head section.
examples/minimal-solidstart/src/global.css Removed Tailwind CSS directives from the global stylesheet.
examples/minimal-solidstart/src/routes/api/uploadthing.ts Changed export structure for upload handlers to define separate GET and POST functions.
examples/minimal-solidstart/src/routes/index.tsx Enhanced upload event handling with new logging and alert features.
examples/minimal-solidstart/src/server/uploadthing.ts Renamed type alias for the file router from OurFileRouter to UploadRouter.
examples/minimal-solidstart/src/utils/uploadthing.ts Updated type parameters in upload-related functions to use UploadRouter.
examples/minimal-solidstart/tailwind.config.ts Removed Tailwind CSS configuration file.
examples/minimal-solidstart/tsconfig.json Modified TypeScript compiler options, changing module resolution and type definitions.

Possibly related PRs

Suggested labels

📚 documentation

Suggested reviewers

Poem

In the garden of code, changes bloom bright,
With uploads enhanced, and scripts taking flight.
PostCSS and Tailwind, now just memories past,
As we hop to new features, our joy unsurpassed!
So here's to the updates, both clever and spry,
A rabbit's delight, as we reach for the sky! 🐇✨

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 39be2023654566b1337ad6938e3fd0285d9f97e7 and 82611ef6cbaadfbbfcc6bf13dfc83b3e9386a926.
Files ignored due to path filters (1) * `pnpm-lock.yaml` is excluded by `!**/pnpm-lock.yaml`
Files selected for processing (12) * examples/minimal-solidstart/package.json (1 hunks) * examples/minimal-solidstart/postcss.config.cjs (0 hunks) * examples/minimal-solidstart/src/app.tsx (1 hunks) * examples/minimal-solidstart/src/entry-client.tsx (1 hunks) * examples/minimal-solidstart/src/entry-server.tsx (1 hunks) * examples/minimal-solidstart/src/global.css (0 hunks) * examples/minimal-solidstart/src/routes/api/uploadthing.ts (1 hunks) * examples/minimal-solidstart/src/routes/index.tsx (2 hunks) * examples/minimal-solidstart/src/server/uploadthing.ts (1 hunks) * examples/minimal-solidstart/src/utils/uploadthing.ts (2 hunks) * examples/minimal-solidstart/tailwind.config.ts (0 hunks) * examples/minimal-solidstart/tsconfig.json (1 hunks)
Files not reviewed due to no reviewable changes (3) * examples/minimal-solidstart/postcss.config.cjs * examples/minimal-solidstart/src/global.css * examples/minimal-solidstart/tailwind.config.ts
Files skipped from review as they are similar to previous changes (9) * examples/minimal-solidstart/package.json * examples/minimal-solidstart/src/app.tsx * examples/minimal-solidstart/src/entry-client.tsx * examples/minimal-solidstart/src/entry-server.tsx * examples/minimal-solidstart/src/routes/api/uploadthing.ts * examples/minimal-solidstart/src/routes/index.tsx * examples/minimal-solidstart/src/server/uploadthing.ts * examples/minimal-solidstart/src/utils/uploadthing.ts * examples/minimal-solidstart/tsconfig.json
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 2:57pm
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **legacy-docs-uploadthing** | ⬜️ Ignored ([Inspect](https://vercel.com/pinglabs/legacy-docs-uploadthing/FdJxqdckeMjq1kHmFDBvmtGobvQ4)) | [Visit Preview](https://legacy-docs-uploadthing-git-fork-juraj98-solidstart-pinglabs.vercel.app) | | Sep 24, 2024 2:57pm |
juraj98 commented 1 week ago

Broke pnpm-lock.yaml. I'll close this and reopen again 🤦