pingdotgg / uploadthing

File uploads for modern web devs
https://uploadthing.com
MIT License
4.26k stars 315 forks source link

chore: sync key usage on upload #998

Closed juliusmarminge closed 1 month ago

juliusmarminge commented 1 month ago

ref: https://discord.com/channels/966627436387266600/1292693436184531061

Summary by CodeRabbit

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 5ea847a1b25a14093f933073f84aedb02839abcc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------- | ----- | | uploadthing | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 8:51pm
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **legacy-docs-uploadthing** | ⬜️ Ignored ([Inspect](https://vercel.com/pinglabs/legacy-docs-uploadthing/FLFdBoooBeSfn3rd5bAYDh5GZPeo)) | [Visit Preview](https://legacy-docs-uploadthing-git-sync-key-usage-on-upload-pinglabs.vercel.app) | | Oct 7, 2024 8:51pm |
coderabbitai[bot] commented 1 month ago

Walkthrough

The changes in this pull request involve the addition of a new import for the version from package.json in two files: upload.browser.ts and upload.server.ts. In both files, the uploadWithProgress and uploadWithoutProgress functions respectively have been updated to include a new header, x-uploadthing-version, in their HTTP requests. This change allows for the tracking of the version during uploads without altering the existing function signatures or overall logic.

Changes

File Change Summary
packages/uploadthing/src/internal/... Added import for version from package.json and included x-uploadthing-version header in uploadWithProgress and uploadWithoutProgress functions.

Possibly related PRs

Suggested labels

📚 documentation, examples

Poem

In the land of uploads, so bright and keen,
A version was added, a header unseen.
With x-uploadthing-version, we track with delight,
Each file that we send takes a wondrous flight!
So hop along, friends, let the uploads commence,
With versioning magic, we leap o'er the fence! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
pkg-pr-new[bot] commented 1 month ago

Open in Stackblitz

More templates

- [@example/minimal-appdir](https://pkg.pr.new/template/55431989-e480-4e18-970d-0f1d1ebbc092) - [@example/minimal-astro-react](https://pkg.pr.new/template/c337574b-8f71-4eef-8ed1-269790df3adb) - [@example/minimal-expo](https://pkg.pr.new/template/d2039be9-9381-4e9d-8818-56d25c437bfa) - [@example/minimal-nuxt](https://pkg.pr.new/template/d0f85587-10db-4f60-8f24-78dffe839525) - [@example/minimal-pagedir](https://pkg.pr.new/template/6505faa3-c3e3-4626-a1b0-f26290cd6a79) - [@example/minimal-solidstart](https://pkg.pr.new/template/0c8ba63f-f2ff-4ace-80c5-6adafae9ecd3) - [@example/minimal-sveltekit](https://pkg.pr.new/template/75663e43-69e3-47ff-bc81-bfee2cca971e) - [@example/minimal-tanstack-start](https://pkg.pr.new/template/91d5beca-0360-42dc-920a-b0185094b8bd)

pnpm add https://pkg.pr.new/pingdotgg/uploadthing@998

commit: 5ea847a

github-actions[bot] commented 1 month ago

📦 Bundle size comparison

Bundle Size (gzip) Visualization
Main 26.03KB See Treemap 📊
PR (b11a12f439fd7a263208facdf6b73277f957242e) 26.04KB See Treemap 📊
Diff ↑5.00B
github-actions[bot] commented 1 month ago

A new canary is available for testing. You can install this latest build in your project with:

pnpm add @uploadthing/expo@7.0.3-canary.463ce07
pnpm add @uploadthing/mime-types@0.3.1-canary.463ce07
pnpm add @uploadthing/nuxt@7.0.3-canary.463ce07
pnpm add @uploadthing/react@7.0.3-canary.463ce07
pnpm add @uploadthing/shared@7.0.3-canary.463ce07
pnpm add @uploadthing/solid@7.0.3-canary.463ce07
pnpm add @uploadthing/svelte@7.0.3-canary.463ce07
pnpm add uploadthing@7.0.3-canary.463ce07
pnpm add @uploadthing/vue@7.0.3-canary.463ce07