search

pingidentity / helm-charts

Apache License 2.0
22 stars 31 forks source link

Include the image tag on the FQN #266

Closed johnnyhuy closed 2 years ago

johnnyhuy commented 2 years ago

This is a follow up to #265

We've found out that the FQN also includes the image tag. When we tried using our deployment tooling, it doubled up the tag field causing deployment errors due to a malformed image name.

...
repositoryFqn: 123.docker.io/johnnyhuy/pingfederate:latest
tag: latest
...
# Output: 123.docker.io/johnnyhuy/pingfederate:latest:latest

...
repositoryFqn: 123.docker.io/johnnyhuy/pingfederate:latest
tag: ''
...
# Output: 123.docker.io/johnnyhuy/pingfederate:latest:

This patch should give the user the full ability to do whatever they want on the repositoryFqn values field without being mindful of adding a tag in a separate values field.

I've updated relevant documentation 🙏

johnnyhuy commented 2 years ago

FYI @wesleymccollam

wesleymccollam commented 2 years ago

@johnnyhuy, this is in the most recent Helm release (0.8.9). Again, a great addition to the chart!

henryrecker-pingidentity commented 2 years ago

Hey @johnnyhuy , we've just added a commit to master (https://github.com/pingidentity/helm-charts/commit/e5e9b21cdfa814bee023e68a4012c76c9a4f1ba7) that changes the behavior of repositoryFqn to be consistent with our other fields for specifying image repository and tags. We updated the template so that repositoryFqn is expected under the image: field, like the other image-related fields. And we now append the image.tag value on the end of the repositoryFqn, since the repositoryFqn should only be the repository URL. These changes will be included in the next release (0.9.1) which should be out in the next week or so.