pingidentity / helm-charts

Apache License 2.0
22 stars 31 forks source link

Api Version conditional logic not working on ingresss. #268

Closed samir-gandhi closed 2 years ago

samir-gandhi commented 2 years ago

https://github.com/pingidentity/helm-charts/blob/master/charts/ping-devops/templates/pinglib/_ingress.tpl#L7

This section is intended to return networking.k8s.io/v1 if the cluster is 1.19+ and networking.k8s.io/v1beta1 otherwise. Currently it is only capable of achieving this on helm template .. on helm install it always returns networking.k8s.io/v1beta1. This means the helm chart does not support version kube-version 1.22+

While fixing this, I recommend we also add the kubernetes version somewhere, probably annotations. When you upgrade your cluster from <1.22 to 1.22 existing ingresses have trouble upgrading. Having the current kube version would make it easier to determine what the deployment aligns to and gives admins something to search for when upgrading.

henryrecker-pingidentity commented 2 years ago

Fixed in 153ba8b7849d0f6bf05c5ad3e66e9d054e6440f4