search

pingidentity / helm-charts

Apache License 2.0
22 stars 31 forks source link

Don't Override the Deployments Replicas When Set With Autoscaling #277

Closed StokesM closed 9 months ago

StokesM commented 9 months ago

When the replica count is set with autoscaling the replicas value should not be provided to the deployment template because during helm upgrade time the deployments replicas is reset to this number for the duration of the deployment essentially breaking the expected rolling update deployment strategy.

This pull request would resolve issue #276.

I know the contributing guidelines state that third party contributions are not accepted but this gives some context the changes mentioned in the issue and you can just take the change!

henryrecker-pingidentity commented 9 months ago

We've pushed this change and we'll be putting out a release in the next couple weeks that will include it.