pingidentity / terraform-provider-davinci

PingOne DaVinci Terraform Provider
https://registry.terraform.io/providers/pingidentity/davinci/latest
Mozilla Public License 2.0
4 stars 1 forks source link

Review input validation for schema #39

Closed patrickcping closed 2 months ago

patrickcping commented 1 year ago

Ideally we'll have input validation on fields that might need it because of API restrictions.

The following example is the PingOne environment ID, which will use a pre-defined validator

Example (without validation): https://github.com/pingidentity/terraform-provider-davinci/blob/1a2d766c9ea4d46438d888b105b2157ca636f7d1/internal/service/davinci/resource_application.go#L21-L25

Example (with validation) https://github.com/pingidentity/terraform-provider-pingone/blob/a2e6d79e38d7305040f9a875fca0ee259d0e76bb/internal/service/sso/resource_group.go#L34-L40

patrickcping commented 2 months ago

Deferred to activity that merges DaVinci capability to the PingOne Terraform provider