pingidentity / terraform-provider-pingfederate

Terraform PingFederate Provider
https://registry.terraform.io/providers/pingidentity/pingfederate/latest/docs
Other
11 stars 3 forks source link

Version Check Incorrect with PingFederate 12.1.2 #356

Open colinhuckstep opened 1 week ago

colinhuckstep commented 1 week ago

Community Note

Thank you for opening an issue. Please note that we try to keep the Terraform issue tracker reserved for bug reports and feature requests. For general usage questions, please see: https://www.terraform.io/community.html.

PingFederate Terraform provider Version

0.15.0

PingFederate Version

12.1.2

Terraform Version

1.9.5

Affected Resource(s)

Provider PingFed version Check

Terraform Configuration Files

provider "pingfederate" {
    insecure_trust_all_tls = true
    https_host             = "12.1.2"
    username               = jsondecode(data.aws_secretsmanager_secret_version.pingfed_creds.secret_string)["PF_Setup_Username"]
    password               = jsondecode(data.aws_secretsmanager_secret_version.pingfed_creds.secret_string)["PF_Setup_Password"]
}

Debug Output

Panic Output

Expected Behavior

terraform apply runs without error.

Actual Behavior

╷ │ Warning: PingFederate patch version '12.1.0' is not recognized by this version of the PingFederate terraform provider │ │ with provider["registry.terraform.io/pingidentity/pingfederate"], │ on terraform.tf line 27, in provider "pingfederate": │ 27: provider "pingfederate" { │ │ Assuming the latest patch version supported by the provider: '12.1.0' │ │ (and one more similar warning elsewhere) ╵

Seems like there's an error with the version check logic when running anything higher than 12.1.0.

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

  1. terraform apply

References

wesleymccollam commented 1 week ago

Hey @colinhuckstep, thank you for submitting the issue! The provider has not been updated for any new attributes that may be present after 12.1. However, any present in 12.1 or earlier will be supported. You can use 12.1 to avoid this warning and the provider will use the latest PingFederate patch that it supports on that particular major-minor version.

colinhuckstep commented 1 week ago

Thanks. I'll update my setup scripts to strip the point release from version for now.