pingjiang / glsl4idea

Automatically exported from code.google.com/p/glsl4idea
0 stars 0 forks source link

Text is unreadable on dark background #43

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Start IDEA with the Darcula theme (or any other theme with white-text-on-black) 
and open a GLSL file. All the text but keywords (braces, operators, dots, 
parentheses) are now black on a black background, making the editor unusable. 
It seems that the highlighter needs to register the text as "General text" so 
that it gets the same foreground colour as other text.

Original issue reported on code.google.com by d...@shadowburst.com on 29 May 2013 at 2:41

GoogleCodeExporter commented 9 years ago
It's possible to edit many of the symbol types to be readable, however 
operators such as assignments and comparisons appear to be fixed as black.

Also the shader region itself is set on a greenish background which looks quite 
ugly on a dark background theme.

Original comment by drewnoakes on 27 Jul 2013 at 7:27

GoogleCodeExporter commented 9 years ago
This line seems to be the culprit for black identifiers:

https://code.google.com/p/glsl4idea/source/browse/src/glslplugin/GLSLHighlighter
.java#85

It looks like creating a new type of colour class for 'other' would be a good 
idea, registering it in this source file too:

https://code.google.com/p/glsl4idea/source/browse/src/glslplugin/GLSLColorAndFon
tsPage.java#51

Original comment by drewnoakes on 27 Jul 2013 at 7:33

GoogleCodeExporter commented 9 years ago
Seems to be a duplicate of #35.

Original comment by drewnoakes on 29 Jul 2013 at 10:21