Gameboy benchmark creates image data buffer of incorrect size

[GoogleCodeExporter]

gbemu.js, in GameBoyContext, creates a "fake" image-data buffer:

    result.data = new Uint8Array(w * h);

This is wrong though, it should be:

    result.data = new Uint8Array(w * h * 4);

In GameBoyCore.prototype.dispatchDraw, 75% of the writes to that array are 
curently out-of-bounds. This doesn't make the benchmark very representative of 
the original emulator.

Original issue reported on code.google.com by JanDeMo...@gmail.com on 27 Feb 2013 at 8:25

[GoogleCodeExporter]

Thanks for pointing this out, indeed we had recently noticed quite few OOB 
access. We are going to fix it in the next Octane refresh, as this might likely 
change score results on some browser.

Original comment by octane.t...@gmail.com on 28 Feb 2013 at 8:09

• Changed state: Accepted

[GoogleCodeExporter]

should bring up that some of the core code of the test itself has changed in 
the latest version on github. So if you bugfix, make sure you're aware in case 
you're grabbing the latest copy of the original source online.

Original comment by grantgal...@gmail.com on 8 Mar 2013 at 3:05

[GoogleCodeExporter]

Original comment by octane.t...@gmail.com on 18 Nov 2013 at 3:22

• Changed state: Fixed