search

pingles / clj-hector

Simple Cassandra client for Clojure
42 stars 19 forks source link

adding key-validator option to make-column-family #32

Closed ryfow closed 12 years ago

ryfow commented 12 years ago

Just wrapping BasicColumnFamilyDefinition.setKeyValidationClass() in make-column-family.

I'd be happy to write a test for it if someone lets me know how to run the tests without getting the following exception: java.lang.ClassNotFoundException: org.apache.cassandra.service.EmbeddedCassandraService

pingles commented 12 years ago

Hi Ryan,

Thanks for your patch!

I've just pushed a change so that the project builds with Leiningen 2- could you check you're using lein 2 and try running the tests again? Let me know if you still get a ClassNotFoundException.

Thanks, Paul

ryfow commented 12 years ago

The tests run now, thanks. If there's a compilation problem, it hangs for some reason. I can live with that.

I updated tests changed the key name to :k-validator to match some of your other names. Do you prefer the commits to be squashed?

pingles commented 12 years ago

Nope that's fine- I'll merge it in. Thanks again for your contribution!

pingles commented 12 years ago

I've merged these in and pushed a 0.2.2 release to Clojars.

ryfow commented 12 years ago

Thanks!