pingswept / pysolar

Pysolar is a collection of Python libraries for simulating the irradiation of any point on earth by the sun. It includes code for extremely precise ephemeris calculations.
http://pysolar.org
GNU General Public License v3.0
372 stars 125 forks source link

No pytz #125

Closed mborsetti closed 4 years ago

mborsetti commented 4 years ago

Removed dependency on pytz library by using standard library datetime (already imported) to get UTC time, as per note in https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow on how to obtain an aware current UTC datetime.

That one line was the entire use of the pytz library.

P.S. Followed instructions at https://github.com/pingswept/pysolar/blob/master/development-notes.md

pingswept commented 4 years ago

Thanks for the patch, Mike! I had no idea that was even possible. (Maybe it's new in Python 3?) Anyway, thanks.

mborsetti commented 4 years ago

Hi Brandon, no sweat. Not sure about Python 2 as I never learned it, but I do remember reading somewhere that doing timezones in Python 2 was even more difficult than it is in 3!