search

pingswept / pysolar

Pysolar is a collection of Python libraries for simulating the irradiation of any point on earth by the sun. It includes code for extremely precise ephemeris calculations.
http://pysolar.org
GNU General Public License v3.0
372 stars 125 forks source link

Revert "No pytz" #126

Closed pingswept closed 4 years ago

pingswept commented 4 years ago

Reverts pingswept/pysolar#125

Sorry, I have to revert this, as it breaks a bunch of tests. Specifically, it breaks: pysolar/test/test_datetime_tzinfo.py pysolar/test/test_hour_angle.py pysolar/test/test_numpy.py

I suspect it actually breaks two other tests as well. The whole list is here: https://github.com/pingswept/pysolar/search?q=pytz&unscoped_q=pytz

I would welcome a revised patch that made the tests behave sensibly, while also removing the pytz dependency. Sorry to be a stickler!

mborsetti commented 4 years ago

Oh, I missed this pull (and the tests!). Will try to contribute a more complete pull request.