search

pingswept / pysolar

Pysolar is a collection of Python libraries for simulating the irradiation of any point on earth by the sun. It includes code for extremely precise ephemeris calculations.
http://pysolar.org
GNU General Public License v3.0
372 stars 125 forks source link

Release current code to PyPI #131

Closed mborsetti closed 3 years ago

mborsetti commented 3 years ago

Would be nice to have the code without the pytz requirement (#130 ) and without the I don't know about leap seconds after 2018 (#119 ) UserWarning available through pip!

pingswept commented 3 years ago

Reasonable request; will try to do that soon. Feel free to post a reminder if I don't get around to it in a week or two.

mborsetti commented 3 years ago

I am feeling very free to post a reminder ;)

Thanks for everything.

pingswept commented 3 years ago

Reminder appreciated. It’s in my queue, and nearing the top. (Okay, let’s be honest, I only sort of have a queue, it’s more like a vague cloud of responsibilities raining down on me at random, but I’m getting there.)

pingswept commented 3 years ago

Quick question @mborsetti: pytz can be removed from requirements.txt and python3-pysolar.spec, right? Yesterday, I tried running test_solar.py, but was prompted to install pytz, which strikes me as wrong. I suspect requirements.txt was at fault.

mborsetti commented 3 years ago

@pingswept sorry, the re-reapplication of the patch for some reason (i.e. my bad PR) missed reapplying the update to solar.py, which still had a dependency. And yes, I hadn't updated any of the build files.

I am submitting the cleanup as PR #132 ; all 82 tests are running fine without pytz installed.

mborsetti commented 3 years ago

The working PR is #134

pingswept commented 3 years ago

Okay, 0.9 is on PyPI! Let me know if there are any weird problems. Thanks for bugging me (really!).