search

pingswept / pysolar

Pysolar is a collection of Python libraries for simulating the irradiation of any point on earth by the sun. It includes code for extremely precise ephemeris calculations.
http://pysolar.org
GNU General Public License v3.0
373 stars 125 forks source link

Supported Python versions #97

Closed codingjoe closed 5 years ago

codingjoe commented 5 years ago

Hi there!

I think the documentation is a little bit outdated. The latest version 0.8.0 does only support Python 3.6+. The documentation points to 3.4 and talks about not supporting python 2.

This was the commit breaking <3.6 support: https://github.com/pingswept/pysolar/commit/6c52c700a745838f8baa1188bc8a5dd7f850a682#r31253580

I don't really mind about supporting anything but Python 3.7, but I guess the documentation could be improved.

Best -Joe

pingswept commented 5 years ago

Good point. A patch to fix that is welcome, from you or anyone else.

codingjoe commented 5 years ago

What do you want me to fix? the documentation or make the package compatible down to a certain Python version? I usually try to stay 3.5+ compatible because of Debian.

pingswept commented 5 years ago

Either path is acceptable to me. If there is an easy workaround to the absence of the ModuleNotFound exception, I'd slightly prefer to support a broader range of Python versions, but if not, just changing the docs to 3.6+ is fine.