search

pingzing / LittleBuster

A tiny WoW TBC Classic replacement for RatingBuster.
GNU General Public License v3.0
6 stars 4 forks source link

Spell hit is detected as spell crit in German #26

Closed Srljm closed 2 years ago

Srljm commented 2 years ago

Hi.

Little Buster assumes that around 16 spell crit equals 1%, but this is wrong. Its actually around or exactly 22.1 spell crit.

Example source on wowhead: https://tbc.wowhead.com/guides/classic-the-burning-crusade-stats-overview In all my other addons or stat lists it also checks out at this value.

pingzing commented 2 years ago

This sounds like an issue with a specific item in a specific locale. You can see the spell crit calculation here: https://github.com/pingzing/LittleBuster/blob/15e6e363f515871ff0f2994a7f19aafea5773356/src/ratingConversion.tl#L46 and if you plug in a level 70, it works out to about 22.1 -> 1%.

Which language are you playing in, and which item(s) are you seeing this on? There have been some issues in the past with Spell Crit being incorrectly picked up as Spell Hit, which could be what you're seeing.

Srljm commented 2 years ago

I play in german where Spell Crit is called "kritische Zaubertrefferwertung" and Spell Hit "Zaubertrefferwertung". I can see now where the mixup originates, haha. And yes, the issue is on all slots and items.

pingzing commented 2 years ago

Ah! My first German bug report. With as little testing as I do in other languages, I'm surprised I don't have more =P

But thanks for the report. I need to put out an update for 2.5.4 anyway, so I may have some time to take a look this weekend.

Srljm commented 2 years ago

Thank you.

pingzing commented 2 years ago

Found some time today, and was able to get it sorted out without much trouble. Closed by eb045fb14e3d06fbee0e93d4e3978423584463d7. Will go out in 1.14.0.