pink-room / kotlin-multiplatform-template

Kotlin Multiplatform Template
Apache License 2.0
196 stars 26 forks source link

[SECURITY] Build downloads code over HTTP instead of HTTPS #6

Closed JLLeitschuh closed 4 years ago

JLLeitschuh commented 4 years ago

CWE-829: Inclusion of Functionality from Untrusted Control Sphere CWE-494: Download of Code Without Integrity Check

The build files indicate that this project is resolving dependencies over HTTP instead of HTTPS. Any of these artifacts could have been MITM to maliciously compromise them and infect the build artifacts that were produced. Additionally, if any of these JARs or other dependencies were compromised, any developers using these could continue to be infected past updating to fix this.

This vulnerability has a CVSS v3.0 Base Score of 8.1/10 https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator?vector=AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:H

This isn't just theoretical

POC code has existed since 2014 to maliciously compromise a JAR file inflight. See:

MITM Attacks Increasingly Common

See:

Source Locations

More Information

mitm_build Want to take over the Java ecosystem? All you need is a MITM!

bffcorreia commented 4 years ago

Thx for the report @JLLeitschuh! This is now fixed in the PR 7.