search

pinkary-project / pinkary.com

Create a landing page for all your links and connect with like-minded people without the noise.
https://pinkary.com
GNU Affero General Public License v3.0
1.16k stars 270 forks source link

it is possible to post multiple images. #435

Closed MrPunyapal closed 1 month ago

MrPunyapal commented 2 months ago

Here, I'm not verified and I'm not able to upload images but as limitation of markdown parser I'm able to post multiple images.

https://github.com/user-attachments/assets/4894fe9c-a1ba-4a5d-9ec2-49eb4fe15a65

steven-fox commented 2 months ago

@MrPunyapal Similar to #434, isn't this issue no longer an issue?

MrPunyapal commented 2 months ago

@steven-fox multiple images are still not allowed 🤔

steven-fox commented 2 months ago

@MrPunyapal Ah. I see now. We explicitly restrict uploading to one image per post, but we don't restrict multiple image elements within the markdown so it's possible for a user to display multiple images in a post as long as they are already uploaded to the server previously. I thought your issue was specifically regarding the "non verified user" aspect haha.

I suppose we could update the ImageProviderParsable to delete all instances of image markdown text other than the first...

That said, I highly doubt people will abuse this so I'd personally focus on other features/bugs first and come back to this if/when users start to abuse it frequently.

steven-fox commented 1 month ago

Going to close this until this becomes an actual issue. Personally, I don’t think it will. We limit uploads, which is what really matters. If people want to go out of there way to write the markdown to show more photos in a single post, it’ll be hidden behind a “Show More” anyway.