pinkary-project / pinkary.com

Create a landing page for all your links and connect with like-minded people without the noise.
https://pinkary.com
GNU Affero General Public License v3.0
1.26k stars 309 forks source link

Remove Pulse from production #667

Open nunomaduro opened 4 weeks ago

steven-fox commented 3 weeks ago

Nuno, do we want to:

  1. Fully remove Pulse from the repo (remove dependency, update/remove migration, etc.)?
  2. Leave the code intact but disable via PULSE_ENABLED = false in .env?
  3. Alter the sampling for some of the recorders?
  4. Make a new sqlite database file specifically for pulse records that doesn't need to be backed up, can be vacuumed as needed, etc.?

I feel like keeping Pulse running on production for exceptions, and slow processing is wise before we migrate to something like Sentry.

Whatcha think?

CamKem commented 3 weeks ago

I think that's a good solution.

I don't think we need to remove pulse, it's useful for metrics other than exceptions too.

As your per suggestion: Isolating the pulse data is the key, Then the aggregate data is seperate from user data. We can setup to flatten the data or wipe the db periodically if needed.

CamKem commented 3 weeks ago

Sentry will be excellent upgrade for managing exceptions.

Moving jobs to horizon / Redis might also be worth considering during this process too, or at least put on the roadmap.