pinkfish / flutter_native_timezone

Apache License 2.0
80 stars 163 forks source link

Add ios to platforms #21

Closed nohli closed 3 years ago

nohli commented 3 years ago

Since the last version iOS doesn't work any more. This PR fixes it.

https://github.com/pinkfish/flutter_native_timezone/issues/9#issuecomment-790959357

There have been two errors in the package. Fixed them, so the tests pass.

nohli commented 3 years ago

@pinkfish still the same error in the latest release...I don't know what happened...when I do pod install from my fork, it works...pod install from your release, it doesn't.

Edit: This is the pubspec.yaml from 1.0.9. Looks like the version doesn't include this PR.

name: flutter_native_timezone
description: A flutter plugin for getting the local timezone of the os.
version: 1.0.9
homepage: https://github.com/pinkfish/flutter_native_timezone

environment:
  sdk: '>=2.12.0 <3.0.0'
  flutter: ">=1.12.0"

dependencies:
  flutter:
    sdk: flutter

dev_dependencies:
  flutter_test:
    sdk: flutter

# The following section is specific to Flutter.
flutter:
  plugin:
    platforms:
      android:
        package: com.whelksoft.flutter_native_timezone
        pluginClass: FlutterNativeTimezonePlugin
      macos:
        pluginClass: FlutterNativeTimezonePlugin

fork: fork

release: release

pinkfish commented 3 years ago

Weird, let me double check. I compiled on ios myself yesterday, should be working. Sorry.

On Fri, 5 Mar 2021 at 00:25, nohli notifications@github.com wrote:

@pinkfish https://github.com/pinkfish still the same error in the latest release...I don't know what happened...when I do pod install from my fork, it works...pod install from your release, it doesn't:

fork: [image: fork] https://user-images.githubusercontent.com/43643339/110087975-99914b80-7d94-11eb-80f1-962d848d84f0.png

release: [image: release] https://user-images.githubusercontent.com/43643339/110088011-a0b85980-7d94-11eb-996b-5b10469070cd.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pinkfish/flutter_native_timezone/pull/21#issuecomment-791251557, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATOMMKZ5YQDVCQDHNGSP4LTCCIRLANCNFSM4YUBNLGA .

nohli commented 3 years ago

Probably, if you just publish a new version, it will work.

bzwear commented 3 years ago

Hi guys, I'm still having the issue after I upgrade to flutter 2.

`[VERBOSE-2:ui_dart_state.cc(186)] Unhandled Exception: MissingPluginException(No implementation found for method getLocalTimezone on channel flutter_native_timezone)

0 MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:156:7)

#1 FlutterNativeTimezone.getLocalTimezone (package:flutter_native_timezone/flutter_native_timezone.dart:12:9) ` Thank you for the valuable package by the way!
nohli commented 3 years ago

New version works:

flutter_native_timezone: ^1.0.10