search

pinkfish / flutter_places_dialog

Google places picker plugin for flutter. Opens up the google places picker on ios and android returning the chosen place back to the flutter app.
Other
44 stars 10 forks source link

Add Deprecation warning #14

Open josh-burton opened 5 years ago

josh-burton commented 5 years ago

Since the Google Places Place Picker is now deprecated you should add a clear warning to this plugin so people are aware before using it.

pinkfish commented 5 years ago

Interesting. What is it replaced with? Just the places API?

On Fri, Apr 12, 2019, 6:13 PM Josh Burton notifications@github.com wrote:

Since the Google Places Place Picker is now deprecated you should add a clear warning to this plugin so people are aware before using it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pinkfish/flutter_places_dialog/issues/14, or mute the thread https://github.com/notifications/unsubscribe-auth/ACbmMef5z9B7CRQfQSp0iuzkBO-hgd8aks5vgS8ngaJpZM4ctxDi .

josh-burton commented 5 years ago

From here

Notice: The Place Picker (Android, iOS) is deprecated as of January 29, 2019. This feature will be turned off on July 29, 2019, and will no longer be available after that date. To continue using the Place Picker with Places SDK for iOS v.2.7.0 through the deprecation period, do NOT disable the Places SDK for iOS. Read the migration guides (Android, iOS) to learn more.

Basically the places sdk from play services is now deprecated, and there is a new one: com.google.android.libraries.places:1.1.0.

This new SDK doesn't include the place picker, but it does include some form of autocomplete UI.

pinkfish commented 5 years ago

Looks like the auto-complete api might be hard to do in flutter because it renders in a fragment. There is a compatibility library we can use by the looks.

Probably should make a flutter places picker that just uses flutter components and the places api directly.

On Fri, 12 Apr 2019 at 18:20, Josh Burton notifications@github.com wrote:

From here https://developers.google.com/places/android-sdk/placepicker

Notice: The Place Picker (Android, iOS) is deprecated as of January 29, 2019. This feature will be turned off on July 29, 2019, and will no longer be available after that date. To continue using the Place Picker with Places SDK for iOS v.2.7.0 through the deprecation period, do NOT disable the Places SDK for iOS. Read the migration guides (Android, iOS) to learn more.

Basically the places sdk from play services is now deprecated, and there is a new one: com.google.android.libraries.places:1.1.0.

This new SDK doesn't include the place picker, but it does include some form of autocomplete UI.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pinkfish/flutter_places_dialog/issues/14#issuecomment-482764242, or mute the thread https://github.com/notifications/unsubscribe-auth/ACbmMajdR9ohgULjNotGrungD127Ccjrks5vgTDbgaJpZM4ctxDi .

josh-burton commented 5 years ago

Yeah there is a package that does that and works quite well: https://pub.dartlang.org/packages/flutter_google_places

pinkfish commented 5 years ago

Nice! Ok, that didn't exist when I did this package :)

On Fri, 12 Apr 2019 at 20:57, Josh Burton notifications@github.com wrote:

Yeah there is a package that does that and works quite well: https://pub.dartlang.org/packages/flutter_google_places

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pinkfish/flutter_places_dialog/issues/14#issuecomment-482773712, or mute the thread https://github.com/notifications/unsubscribe-auth/ACbmMcXRnxdLqFI5zIWQOH77182au_KTks5vgVW4gaJpZM4ctxDi .

pmrajani commented 5 years ago

@pinkfish You should add clear comment for this plugins as now this will not work because classes you used is deprecated now. I have spent so much time to check my code issue and i finally realize this plugins will no more work in android.

josh-burton commented 5 years ago

Or perhaps archive this repository so it's clear that way.

pmrajani commented 5 years ago

@athornz is their any alternative way to implement place autocomplete view?

josh-burton commented 5 years ago

Have you tried the package I mentioned above?