pinkfish / flutter_rtmppublisher

Publisher to rtmp using the camera plugin as a basis to do all the basic camera/record management.
BSD 3-Clause "New" or "Revised" License
95 stars 121 forks source link

Build errors #1

Open ollyde opened 4 years ago

ollyde commented 4 years ago

Hey, I love that you created this library, really wish I could pay you somehow cause you are saving my ass.

Anyhow; I have some build errors when trying to build this for iOS. Something to do with the POD Logboard, perhaps it just needs updating.

I think you need to upgrade your version of Flutter/Xcode/Android. (developer of this library)

/Users/olly/Projects/spotify_mobile/ios/Pods/Logboard/Sources/Logboard/SocketAppender.swift:149:66: error: 'default' has been renamed to
    'RunLoopMode.defaultRunLoopMode'
            inputStream.schedule(in: runloop!, forMode: RunLoop.Mode.default)
                                                                     ^~~~~~~
                                                                     RunLoopMode.defaultRunLoopMode
    Foundation.RunLoop.Mode:4:23: note: 'default' was introduced in Swift 4.2
        public static let `default`: RunLoopMode
                          ^
    /Users/olly/Projects/spotify_mobile/ios/Pods/Logboard/Sources/Logboard/SocketAppender.swift:153:67: error: 'default' has been renamed to
    'RunLoopMode.defaultRunLoopMode'
            outputStream.schedule(in: runloop!, forMode: RunLoop.Mode.default)
                                                                      ^~~~~~~
                                                                      RunLoopMode.defaultRunLoopMode
    Foundation.RunLoop.Mode:4:23: note: 'default' was introduced in Swift 4.2
        public static let `default`: RunLoopMode
                          ^
    /Users/olly/Projects/spotify_mobile/ios/Pods/Logboard/Sources/Logboard/SocketAppender.swift:174:67: error: 'default' has been renamed to
    'RunLoopMode.defaultRunLoopMode'
            inputStream?.remove(from: runloop!, forMode: RunLoop.Mode.default)
                                                                      ^~~~~~~
                                                                      RunLoopMode.defaultRunLoopMode
    Foundation.RunLoop.Mode:4:23: note: 'default' was introduced in Swift 4.2
        public static let `default`: RunLoopMode
                          ^
    /Users/olly/Projects/spotify_mobile/ios/Pods/Logboard/Sources/Logboard/SocketAppender.swift:178:68: error: 'default' has been renamed to
    'RunLoopMode.defaultRunLoopMode'
            outputStream?.remove(from: runloop!, forMode: RunLoop.Mode.default)
                                                                       ^~~~~~~
                                                                       RunLoopMode.defaultRunLoopMode
    Foundation.RunLoop.Mode:4:23: note: 'default' was introduced in Swift 4.2
        public static let `default`: RunLoopMode
pinkfish commented 4 years ago

Will need to check this. I had it compiling for iOS a couple of days ago though and ran the example which worked.

ollyde commented 4 years ago

@pinkfish Yeah, I got it working for iOS. Btw it's working super great! Basically you just need to patch an old library that's downloaded via pod. It would be nice if we could pass in some props to the streaming (optional).

pinkfish commented 4 years ago

Which version of xcode/ios are you using? This is compiling for me.

On Tue, 12 May 2020 at 14:17, Oliver Dixon notifications@github.com wrote:

Hey, I love that you created this library, really wish I could pay you somehow cause you are saving my ass.

Anyhow; I have some build errors when trying to build this for iOS.

/Users/olly/Projects/spotify_mobile/ios/Pods/Logboard/Sources/Logboard/SocketAppender.swift:149:66: error: 'default' has been renamed to 'RunLoopMode.defaultRunLoopMode' inputStream.schedule(in: runloop!, forMode: RunLoop.Mode.default) ^~~ RunLoopMode.defaultRunLoopMode Foundation.RunLoop.Mode:4:23: note: 'default' was introduced in Swift 4.2 public static let default: RunLoopMode ^ /Users/olly/Projects/spotify_mobile/ios/Pods/Logboard/Sources/Logboard/SocketAppender.swift:153:67: error: 'default' has been renamed to 'RunLoopMode.defaultRunLoopMode' outputStream.schedule(in: runloop!, forMode: RunLoop.Mode.default) ^~~ RunLoopMode.defaultRunLoopMode Foundation.RunLoop.Mode:4:23: note: 'default' was introduced in Swift 4.2 public static let default: RunLoopMode ^ /Users/olly/Projects/spotify_mobile/ios/Pods/Logboard/Sources/Logboard/SocketAppender.swift:174:67: error: 'default' has been renamed to 'RunLoopMode.defaultRunLoopMode' inputStream?.remove(from: runloop!, forMode: RunLoop.Mode.default) ^~~ RunLoopMode.defaultRunLoopMode Foundation.RunLoop.Mode:4:23: note: 'default' was introduced in Swift 4.2 public static let default: RunLoopMode ^ /Users/olly/Projects/spotify_mobile/ios/Pods/Logboard/Sources/Logboard/SocketAppender.swift:178:68: error: 'default' has been renamed to 'RunLoopMode.defaultRunLoopMode' outputStream?.remove(from: runloop!, forMode: RunLoop.Mode.default) ^~~ RunLoopMode.defaultRunLoopMode Foundation.RunLoop.Mode:4:23: note: 'default' was introduced in Swift 4.2 public static let default: RunLoopMode

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pinkfish/flutter_rtmppublisher/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATOMMIDJSHCXZIBLJ66ZETRRG4GRANCNFSM4M7FYDFA .

ollyde commented 4 years ago

XCode 11.4.1 Flutter 1.17.1

pinkfish commented 4 years ago

I am using xcode 11.3.1, weird that an older version would complain and a newer one doesn't

You are on alpha flutter? I have 1.17.0 on beta

Thanks, David.

On Wed, 13 May 2020 at 11:50, Oliver Dixon notifications@github.com wrote:

XCode 10.15.4 Flutter 1.17.1

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pinkfish/flutter_rtmppublisher/issues/1#issuecomment-628178635, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATOMMJ7YR2KVRLIWYLFTXLRRLTYFANCNFSM4M7FYDFA .

ollyde commented 4 years ago

There's a big difference between our versions of XCode. 1.17.1 is the latest public stable release :-)

https://flutter.dev/docs/development/tools/sdk/releases

ollyde commented 4 years ago

@pinkfish sorry I'm on XCode 11.4.1 pressed the wrong about while in a meeting

pinkfish commented 4 years ago

Weird, something must have got deprecated between the two versions. Will see if I can upgrade.

ollyde commented 4 years ago

@pinkfish yeah the error was something about Swift 4.2

ollyde commented 3 years ago

@pinkfish unfortunately with Flutter 1.20.XX we can't use the Swift 4.2 flag anymore; any ideas about what we should do with 'default' has been renamed to 'RunLoopMode.defaultRunLoopMode' ?

pinkfish commented 3 years ago

Ahh, not tried to build with the latest flutter. Let me try tomorrow.

On Wed, 30 Sep 2020 at 15:04, Oliver Dixon notifications@github.com wrote:

@pinkfish https://github.com/pinkfish unfortunately with Flutter 1.20.XX we can't use the Swift 4.2 flag anymore; any ideas about what we should do with 'default' has been renamed to 'RunLoopMode.defaultRunLoopMode' ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pinkfish/flutter_rtmppublisher/issues/1#issuecomment-701671288, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATOMMMUWWZNVZCGXDRYP3LSIOTPHANCNFSM4M7FYDFA .

ollyde commented 3 years ago

@pinkfish thanks man, this is an invaluable package for me. :-)

amirmhmdi commented 3 years ago

hi thanks for ur nice plugin it work on android but I have the same issue on ios ! any update for this issue?