pinkfish / flutter_rtmppublisher

Publisher to rtmp using the camera plugin as a basis to do all the basic camera/record management.
BSD 3-Clause "New" or "Revised" License
95 stars 126 forks source link

Null safety support #58

Open babulpatel1309 opened 3 years ago

babulpatel1309 commented 3 years ago
pinkfish commented 3 years ago

I did an update to null safety. Is this still needed?

babulpatel1309 commented 3 years ago

@pinkfish if everything is working as expected then we're good to go :) The PR was actually generated on 19th May 🤣 . At that moment so many libraries were missing this part, so i sat and raised PR for all libraries.

babulpatel1309 commented 3 years ago

@pinkfish i coudn't able to find where exactly did you publish the null safety update?

philipgiuliani commented 3 years ago

@pinkfish you have updated to null safety in the master branch but not in the main branch.

fotiDim commented 2 years ago

@philipgiuliani why is there both a master and a main branch? For sound null safety sdk: ">=2.12.0 <3.0.0" should be defined in pubspec.yaml. I see that this is the case only in master and not main.