pinkshirt / firebreath

Automatically exported from code.google.com/p/firebreath
0 stars 0 forks source link

Plugin version is effectively hard-coded via gen_templates\firebreathWin.rc #97

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create one or more new projects
2. Alter cmake settings (eg. FBSTRING_PLUGIN_VERSION in PluginConfig.cmake)
3. Observe the file version in \projects\<whatever>\gen\firebreathWin.rc

What is the expected output? What do you see instead?

You'd expect the version you see in step 3 to come from a per-project setting, 
probably a variable in PluginConfig.cmake, but instead it comes from the 
gen_templates directory, so it is the same across all projects and not easily 
configurable.

What version of FireBreath are you using? On what operating system and
browsers?

Win32, all browsers.

Unknown FB version - I can't easily see a way to determine this from the 
downloaded source. It was downloaded 1 to 2 months ago, if that's any help!

Original issue reported on code.google.com by kylo...@gmail.com on 1 Nov 2010 at 12:24

GoogleCodeExporter commented 9 years ago
Yeah, this is a known issue, so it's good to get this in here.  We definitely 
should find a good way to abstract this.

In the mean time, you can copy the firebreathWin.rc file to your plugin 
directory and modify it yourself; as of 1.3.0 release it will look for that 
file in your plugin dir before using the default.

Original comment by taxilian on 1 Nov 2010 at 2:21

GoogleCodeExporter commented 9 years ago
I cannot come up with a good solution to this other than copying the file, so 
that will be the recommended method until someone has a better idea =]

Original comment by taxilian on 29 Nov 2010 at 8:22