search

pinkywafer / Calendarific

Calendarific holiday sensor for Home Assistant
MIT License
19 stars 7 forks source link

Show Calendarific Sensors in Home Assistant Calendar #30

Closed Snuffy2 closed 1 year ago

Snuffy2 commented 2 years ago

I believe I have added the Calendar platform into the Calendarific integration. I've done some testing and it is working for me, but others need need to test more for sure.

Fixes: #20

pinkywafer commented 1 year ago

great. I'll look this over and merge if all is well. Thank you very much

pinkywafer commented 1 year ago

ok, having reviewed this, I'm not going to merge, as there is too much going on in this PR. This should be at least 2 seperate PRs - The adding of the calendar should be in a PR Any code styling / cleanup of the existing integration should be separate to the PR adding a new feature.

I'm going to leave the PR open for the time being to see what you would like to do with it: split the additions into a PR on their own, create a separate styling pr if you wish

otherwise, I am happy to add the calendar enhancement using your calendar.py and the associated additions in const and sensor, and will credit you anyway.

Please let me know how you'd like to proceed. If I do not hear from you, I shall do the latter and add the calendar etc and credit you. Thanks

Snuffy2 commented 1 year ago

Fair. I did these PRs months ago and was using a new IDE. I generally have auto-Black linting enabled and must have left it on for this as well. Let me see what I can do to remove the code formatting changes (in both PRs)

Snuffy2 commented 1 year ago

Ok, it wasn't as difficult as I had imagined to revert the formatting changes. There are still a couple remaining but hopefully this is better now.

pinkywafer commented 1 year ago

Thanks