rescue Exception --> rescue LoadError

pinnymz / migration_comments

Comments for your migrations

MIT License

173 stars 31 forks source link

rescue Exception --> rescue LoadError #34

Closed kenaniah closed 8 years ago

kenaniah commented 8 years ago

Rescuing from Exception is dangerous when not rethrown. In this case, a more specific class can be used. This PR uses the LoadError class, which has Gem::LoadError (the actual exception that is thrown) and Gem::ConflictError for descendants.

Rational for this PR here: http://stackoverflow.com/a/10048406/80636

pinnymz commented 8 years ago

Looks good, thanks!