Closed kenaniah closed 8 years ago
Rescuing from Exception is dangerous when not rethrown. In this case, a more specific class can be used. This PR uses the LoadError class, which has Gem::LoadError (the actual exception that is thrown) and Gem::ConflictError for descendants.
Exception
LoadError
Gem::LoadError
Gem::ConflictError
Rational for this PR here: http://stackoverflow.com/a/10048406/80636
Looks good, thanks!
Rescuing from
Exception
is dangerous when not rethrown. In this case, a more specific class can be used. This PR uses theLoadError
class, which hasGem::LoadError
(the actual exception that is thrown) andGem::ConflictError
for descendants.Rational for this PR here: http://stackoverflow.com/a/10048406/80636