pinnymz / migration_comments

Comments for your migrations
MIT License
173 stars 31 forks source link

Silence warnings #39

Open lloeki opened 7 years ago

lloeki commented 7 years ago

When running tests on a project depending on migration_comments some warnings are raised (see below).

This is because with a recent rake (>=11.0), ruby warnings are now on by default.

What do you think about fixing those warnings as well as running the test suite with ruby -w / $VERBOSE = true / t.warning = true ?

/Users/lloeki/.gem/ruby/2.3.4/gems/migration_comments-0.4.1/lib/migration_comments.rb:40: warning: assigned but unused variable - ex
/Users/lloeki/.gem/ruby/2.3.4/gems/migration_comments-0.4.1/lib/migration_comments.rb:53: warning: assigned but unused variable - ex
/Users/lloeki/.gem/ruby/2.3.4/gems/migration_comments-0.4.1/lib/migration_comments/active_record/connection_adapters/table_definition.rb:5: warning: method redefined; discarding old comment=