Closed edennis closed 11 years ago
The fix for dynamic config template looks good - thanks for the patch! I've been wanting to limit the dependency to ActiveRecord for some time. This is now done as well in commit 1bcd8ee5dc44a1b61f580a228791e20465636081, thanks to you.
My reasons for this change are two-fold:
https://github.com/rails/rails/blob/master/railties/lib/rails/application/configuration.rb#L105
Selecting the current database from mysql and storing it in an instance variable gets rid of this dependency.
The tests are running (at least in the same state as they were before with the last two failing b/c of the rails 4 migration). I'd be happy to get your feedback on this. :)