Closed jsumners closed 6 months ago
CI doesn't seem happy
CI doesn't seem happy
Yeah. See my inline review comment.
I give up for now. node:test
in v16 doesn't include t.after
so tspl
isn't usable. But we need tspl
to assert the planned number of assertions. This PR has completely convinced me that the functionality belongs in node:test
and the reasoning of "we want all assertion libraries to work" is a cop out.
Part of https://github.com/pinojs/pino/issues/1762.