fs.SyncWriteStream reached end of life

pinojs / pino-clf

🌲 Transport which transforms Pino HTTP logs into Common Log Format

MIT License

5 stars 0 forks source link

fs.SyncWriteStream reached end of life #2

Closed maksimovicdanijel closed 5 years ago

maksimovicdanijel commented 5 years ago

Hi,

when using pino-clf and trying to save to a file there is an error that SyncWriteStream is not a constructor. Possible solution is to use https://www.npmjs.com/package/syncwritestream which is a drop-in replacement for this function.

@mcollina Do you maybe have a better idea how to solve this issue?

mcollina commented 5 years ago

I think https://github.com/pinojs/pino-toke/blob/master/stdio.js needs to be updated. I don't really know how, I would just aim to make the tests pass

cc @davidmarkclements

mcollina commented 5 years ago

https://www.npmjs.com/package/sonic-boom is what we use in pino.

davidmarkclements commented 5 years ago

should be closed from https://github.com/pinojs/pino-toke/commit/2d22b4fdfd0dbdb12c2f6424196d120fe05fcef5

it's a patch, reinstall and you should be good.