search

pinojs / pino-mongodb

:evergreen_tree: Insert JSON from stdin into MongoDB
MIT License
54 stars 18 forks source link

You don't actually *need* CLI argument #4

Closed JaneJeon closed 5 years ago

JaneJeon commented 5 years ago

In the pino-mongodb.js file, I noticed this bit:

if (argv.length <= 2) {
  argv.push('--help')
}

If you're going with default system installation of Mongo, you don't even need authentication, and all the necessary bits (host, port, db, collection, etc.) are already filled out in the default, so you don't need to force users to pass at least one argument.

If this is a nudge to make users choose something other than the default, I'd rather change the default options to be "good enough" so that most (at least during development phase) users don't have to specify any option.

viktor-ku commented 5 years ago

Closed by you https://github.com/pinojs/pino-mongodb/pull/5

Thanks