search

pinojs / pino-pretty

🌲Basic prettifier for Pino log lines
MIT License
1.27k stars 150 forks source link

Typings missing `minimumLevel` #339

Closed lewisakura closed 2 years ago

lewisakura commented 2 years ago

minimumLevel is a valid option here: https://github.com/pinojs/pino-pretty/blob/e793e646a0b539b3a9aa8b5ab43e64a8d86b05d6/index.js#L57 But it's not available in the typings: Which I assume is because it isn't part of the default options set, so when the typings were written it was missed: https://github.com/pinojs/pino-pretty/blob/e793e646a0b539b3a9aa8b5ab43e64a8d86b05d6/index.js#L30-L48

(psst... what is the default minimum level?)

kibertoad commented 2 years ago

Would you be open to send a PR for this? It would also need a tsd test.

lewisakura commented 2 years ago

Yep, just need to know what the default is for proper documentation.

Edt: Just seems to be trace. I'll PR this now.