search

pinojs / pino-pretty

🌲Basic prettifier for Pino log lines
MIT License
1.27k stars 150 forks source link

Log is incorrect when message ends with \r #414

Open nakamuraos opened 1 year ago

nakamuraos commented 1 year ago

When message log ends with \r, pino-pretty print as below log:

 {"context":"VideoService"}Process 191658: stderr frame= 2000 fps=232 q=29.0 size=    4608kB time=00:01:07.15 bitrate= 562.1kbits/s dup=2 drop=0 speed= 7.8x    
 {"context":"VideoService"}Process 191658: stderr frame= 2080 fps=228 q=29.0 size=    4608kB time=00:01:09.82 bitrate= 540.6kbits/s dup=2 drop=0 speed=7.67x    
 {"context":"VideoService"}Process 191658: stderr frame= 2153 fps=224 q=29.0 size=    4864kB time=00:01:12.23 bitrate= 551.6kbits/s dup=2 drop=0 speed=7.51x    
[06:04:40.243] DEBUG (191393): Page 1: https://domain.com/path {"context":"VideoService"}
 {"context":"VideoService"}Process 191658: stderr frame= 2219 fps=219 q=29.0 size=    5120kB time=00:01:14.44 bitrate= 563.4kbits/s dup=2 drop=0 speed=7.35x    
[06:04:40.629] DEBUG (191393): Page 1: https://domain.com/path {"context":"VideoService"}

Through messageFormat can handle it, but should be --singleLine take this behavior?

mcollina commented 1 year ago

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.