pinojs / pino-pretty

🌲Basic prettifier for Pino log lines
MIT License
1.27k stars 150 forks source link

nodejs started to crash after 9.1.1 #463

Open chrisands opened 1 year ago

chrisands commented 1 year ago

I used pino-pretty@8.0.0 after updating to latest version (10.2.0) I started to receive nodejs crashes after few logs

node[6333]: ../src/tcp_wrap.cc:155:static void node::TCPWrap::New(const FunctionCallbackInfo<v8::Value> &): Assertion `args[0]->IsInt32()' failed.
 1: 0x1089c4dc5 node::Abort() (.cold.1) [/Users/osiyuk/.local/share/fnm/node-versions/v18.14.2/installation/bin/node]
 2: 0x1074481e9 node::Abort() [/Users/osiyuk/.local/share/fnm/node-versions/v18.14.2/installation/bin/node]
 3: 0x107447fe1 node::Assert(node::AssertionInfo const&) [/Users/osiyuk/.local/share/fnm/node-versions/v18.14.2/installation/bin/node]
 4: 0x107522819 node::TCPWrap::New(v8::FunctionCallbackInfo<v8::Value> const&) [/Users/osiyuk/.local/share/fnm/node-versions/v18.14.2/installation/bin/node]
 5: 0x107640c78 v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) [/Users/osiyuk/.local/share/fnm/node-versions/v18.14.2/installation/bin/node]
 6: 0x107640444 v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<true>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/Users/osiyuk/.local/share/fnm/node-versions/v18.14.2/installation/bin/node]
 7: 0x10763fe3b v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/Users/osiyuk/.local/share/fnm/node-versions/v18.14.2/installation/bin/node]
 8: 0x3a4c07d39

I tried different version and discovered that crashes started after pino-pretty@9.1.1. On @9.1.0 it still works okay.

I'll try add repo with reproduction. Maybe you have thoughts why this is happening?

mcollina commented 1 year ago

No clue whatsoever, send out that repro!

ondrejnebesky commented 11 months ago

The same issue here. Interesting though that with two identical laptops and code the issue can only be reproduced only on one of them. Both running inside Docker and directly via npm. Reproduced on node 16, 18, and 20. Downgrading for now as older version seems to work.