pinojs / pino-pretty

🌲Basic prettifier for Pino log lines
MIT License
1.25k stars 147 forks source link

Fix: add missing useOnlyCustomProps options to type definitions #514

Closed pcdevil closed 4 months ago

pcdevil commented 5 months ago

Hello,

I started using pino-pretty in a TypeScript project and noticed the useOnlyCustomProps option is not present in the type definitions module. The JSDoc lists it at L71-72, so I assume it was a copy-paste error at some time.

This pull request addresses this discrepancy by copying the readme's description!

pcdevil commented 5 months ago

@mcollina absolutely! I'm not familiar with tsd, but based on the work on the test suite it seemed adding the property suffice for the test expectation. please let me know if it requires more work 🙇🏼

disclaimer: I opted to amend the existing commit to not clutter the git history - this way the change and the test are located in a single commit. I hope you don't mind!