search

pinojs / pino-sapling

🌲 seed template for creating pino plugins/libraries/transports/utilities/modules
MIT License
2 stars 0 forks source link

bin.js #1

Open davidmarkclements opened 7 years ago

davidmarkclements commented 7 years ago

content seems a little superfluous, possibly misleading (why do we get the realpath and require? what's that for?)

jsumners commented 7 years ago

Completeness? /shrug

I use an extra "bin" script so that I don't have a shebang in my real code. It can go away; I don't mind.

davidmarkclements commented 7 years ago

not saying it should go away - just not sure on the approach of the bin file

but.. maybe it should go away for non-transport templates (cf. #3)

jsumners commented 7 years ago

Honestly, I got the approach from some tutorial somewhere at some point and have just blindly copied and pasted ever since. I haven't taken the time to think about it other than that.

davidmarkclements commented 7 years ago

I think... we need to split into different templates.. based on categorisations of current eco system

for transports we can just do it like pino-elasticsearch (shebang in entry point, no bin file)

davidmarkclements commented 7 years ago

or maybe this is just for transports

we can start there, and strip back for utility modules