pinojs / pino-socket

🌲 A transport for sending pino logs to network sockets
43 stars 14 forks source link

resolves #72 introduce a recovery queue #74

Closed ggrossetie closed 2 years ago

ggrossetie commented 2 years ago

Introduce a recovery queue in order to store data when the connection is lost and send them when the connection is established again.

New options:

This feature is disabled by default. Should we emit a warning if the user enables this feature without a max size?

Since I've updated the Readme.md in #71, I will add documentation for them once #71 is merged.

Resolves #72

ggrossetie commented 2 years ago

This also needs some docs

Yes. To avoid conflicts, I'm waiting on https://github.com/pinojs/pino-socket/pull/71 to be merged before adding documentation.

ggrossetie commented 2 years ago

Documentation added.

I think we need to decide if we want to emit a warning or emit an event when an error occurred while writing data to the TCP socket. There are two cases where we write data to the TCP socket:

mcollina commented 2 years ago

Thanks!