search

pinojs / pino-syslog

🌲 A transport for reformatting pino logs into standard syslog format
30 stars 12 forks source link

Config file attributes are overriden by default config #10

Closed eleon-sqli closed 3 years ago

eleon-sqli commented 3 years ago

The options described in an external configuration file (--config flag) are overriden by the default internal config values. The final option object should be constructed just before the transport assignment block:

const options = Object.assign({}, defaults, jsonOptions, args);

I would like to create a PR but I can't push a branch on this repo.

jsumners commented 3 years ago

See https://guides.github.com/activities/forking/

Also see https://github.com/pinojs/pino-syslog/pull/8#pullrequestreview-540972972 and https://github.com/pinojs/pino-syslog/pull/8#pullrequestreview-541250436

eleon-sqli commented 3 years ago

Thanks... oups forgot to fork...