search

pinojs / pino-syslog

🌲 A transport for reformatting pino logs into standard syslog format
30 stars 12 forks source link

Pino 7 upgrade #13

Closed Eomm closed 3 years ago

Eomm commented 3 years ago

Ref https://github.com/pinojs/pino/issues/1056

jsumners commented 3 years ago

Not sure it matters since this should be a new major, but tests are failing on 12.

mcollina commented 3 years ago

We are still supporting v12 in pino@7.

jsumners commented 3 years ago

We are still supporting v12 in pino@7.

Then tests should pass.

jsumners commented 3 years ago

They are independent modules. We don't know what people do with the socket module. It's really, really, generic and can be used for many things even outside of Pino logs. It should remain a standalone module. Instead, we should be able to pipe transports into one another.

mcollina commented 3 years ago

I meant to add that functionality here, not viceversa as this module is supposed to work with pino-socket. Anyway, I'll add the concept of a pipeline to the transport system.

Eomm commented 3 years ago

I think this needs to embed pino-socket. This module is supposed to be used with it and transports cannot be piped together.

I will try to integrate it

Eomm commented 3 years ago

Testing https://github.com/pinojs/pino-abstract-transport/pull/25 https://github.com/pinojs/pino/pull/1143

mcollina commented 3 years ago

@Eomm pino@7.0.0-rc.8 is out, you can use update this and use pipeline.

Eomm commented 3 years ago

@Eomm pino@7.0.0-rc.8 is out, you can use update this and use pipeline.

Done

Eomm commented 3 years ago

There is something else I can do on this PR?

mcollina commented 3 years ago

@jsumners anything left for you?