search

pinojs / pino-syslog

🌲 A transport for reformatting pino logs into standard syslog format
30 stars 12 forks source link

Optionally add EOL (fix #1) #3

Closed cmwd closed 7 years ago

cmwd commented 7 years ago

After testing the latest release, I found I was wrong about newline. Logs are sent to the Papertail and they are parsed well (probably somehow I missed it during e2e tests or Papertail fixed it). The only remaining thing is that after sending a syslog through pino-socket they are swallowed. With a new line, they are sent back to stdout. I'm not sure if it's an issue of this library or pino-socket.

This works for me, but we can still add this feature because it's increasing readability. What do you think?

jsumners commented 7 years ago

The only remaining thing is that after sending a syslog through pino-socket they are swallowed. With a new line, they are sent back to stdout. I'm not sure if it's an issue of this library or pino-socket.

What do you mean "sending a syslog"? pino-socket is meant to accept Pino logs and transform them into syslog lines. Commit d2dba06d2a5f4d06beafd1c14699b9767456def8 prevents any logs that are not processed from being printed to stdout. If that is not desired behavior, then a separate issue should be filed.

cmwd commented 7 years ago

I'm talking about the following scenario: node ./index.js | pino-syslog | pino-socket. AFAIK it should do three things: transform pino log to syslog format, send it to the receiver and to the stdout. Currently, the log is sent to the receiver but pino-socket is not passing it to the stdout. However, with appended newline in pino-syslog it works as expected.

Anyway, it sounds more like a problem of pino-socket, so I'm going to open an issue in its repository.